Buffer Interior on Geometry does nothing - Relates to Issue #133

[Victor Benso]

Both buffer exterior and buffer full are working as expected, however, when clicking in the "Buffer Interior" button, the Editor Buffer Selection closes without adding the new geometry to the editor.

Steps to reproduce: Import SVG as geometry Object. Edit that geometry. Select an element. Type b Enter buffer distance Leave buffer corner as Round Click Buffer Interior (The dialog closes without adding the buffered line to the geometry.)

Platform: Ubuntu Linux 18.04 FlatCam 8.192 BETA

[Victor Benso]

Looks like the geo library isn't accepting negative buffering size. I've fixed the issue in the same way the external buffer works. But in this case, now the method adds only the internal geometries generated by pre_buffer.buffer.

I've uploaded the fix to:

https://bitbucket.org/vbenso/flatcam/commits/102bac750613d574035811c3be0bb90deffa038f

[Marius Stanciu]

Hi @vbenso !

Thanks Victor! For some reason doing the buffer with negative value (which is permitted) over LineStrings (the geometry type for imported or edited Geometry) creates empty Polygons. I just modified the program structure (I prepare a simple Gerber Editor) and now the location of the functions is in the flatcamEditors folder, FlatCAMGeoEditor.py file. If you like, you can make a pull request so your contribution gets logged :) But you'll have to do it on the test_beta8.913 branch.

Best regards, Marius

[Victor Benso]

Hi Marius, I've tried to create the pull request without success. I didn't have the permissions to create it. Congrats, the Beta branch is looking very good.

[Marius Stanciu]

Thanks, I will ask Juan to update the permissions. Perhaps when he granted me the right to upload on his repository, he may have missed some settings.

[Marius Stanciu]

Fixed by the reporter, Victor Benso, merged in commit 49ce8f2.