Editor changes are lost after Save & Close

[Victor Benso]

After editing a Geometry imported from SVG, when clicking in "Save & Close Editor" the modifications to the geometry are lost.

I've tracked this down to: FlatCAMApp.py (https://bitbucket.org/jpcgt/flatcam/src/40c8ef1cf8d29b139eaf401babe0ccca85367208/FlatCAMApp.py) 2146 to 2151:

                  if isinstance(edited_obj, FlatCAMGeometry):
            obj_type = "Geometry"
            if cleanup is None: # <---- commenting this line avoids losing the modifications
                self.geo_editor.update_fcgeometry(edited_obj)
                self.geo_editor.update_options(edited_obj)
            self.geo_editor.deactivate()

Looks like the cleanup parameter isn't being set properly.

[Victor Benso]

The path for the used file wasn't pointing to the right place.

[Marius Stanciu]

Actually 'cleanup' it's a default parameter for editor2object() function. The issue may be solved by calling the editor2object() slot function within a lambda. I made a commit containing this modification. Could you try and see if the issue you've seen is solved?

[Victor Benso]

Tested here.

The problem is gone now. Thanks for the good job.

[Marius Stanciu]

Solved in commit 06ac0b0