Crash qtSlider Float beta_8.994 - fixed for next version

[Adam Sałata]

Logs

[DEBUG][MainThread] **************** Finished PROJECT loading... ****************
[DEBUG][Dummy-9] 0.091849 seconds adding object and plotting.
[DEBUG][MainThread] build_ui--> FlatCAMObj.build_ui()
[DEBUG][MainThread] build_ui--> FlatCAMObj.build_ui()
[DEBUG][MainThread] ToolIsolation().run() was launched ...
WARNING: QLayout::addChildLayout: layout "" already has a parent
[DEBUG][Dummy-7] ToolIsolation.combined_normal()
[DEBUG][Dummy-7] AppObject.new_object()
[DEBUG][Dummy-7] Calling object constructor...
[DEBUG][Dummy-7] FlatCAMObj.visible()
[DEBUG][Dummy-7] 0.045065 seconds before initialize().
[DEBUG][Dummy-7] New object with name: copper_l1.gbr_iso_combined. 0.001409 seconds executing initialize().
[DEBUG] camlib.Geometry.bounds()
[DEBUG][Dummy-7] Moving new object back to main thread.
[DEBUG][MainThread] on_object_created()
[DEBUG][MainThread] on_object_created --> OC.append()
[DEBUG][MainThread] GeometryObject.set_ui()
[DEBUG][MainThread] set_ui --> FlatCAMObj.to_form()
[DEBUG][MainThread] build_ui--> FlatCAMObj.build_ui()
[DEBUG][Dummy-10] plot --> FlatCAMObj.plot()
[DEBUG][Dummy-10] 0.191829 seconds adding object and plotting.
[DEBUG][MainThread] Generating CNCJob from Geometry ...
[DEBUG][MainThread] on_generatecnc_button_click--> FlatCAMObj.read_form()
[DEBUG][MainThread] Object copper_l1.gbr_iso_combined_cnc has been promised.
[DEBUG][Dummy-11] AppObject.new_object()
[DEBUG][Dummy-11] Calling object constructor...
[DEBUG][Dummy-11] Creating CNCJob object...
[DEBUG][Dummy-11] FlatCAMObj.visible()
[DEBUG][Dummy-11] FlatCAMCNCJob.gcode_header()
[DEBUG][Dummy-11] 0.096221 seconds before initialize().
[DEBUG][Dummy-11] Creating a CNCJob out of a multi-geometry
[DEBUG] geometry_tool_gcode_gen()
[DEBUG] 6 paths
[DEBUG] Using RTree path optimization.
[DEBUG] Indexing geometry before generating G-Code...
[DEBUG] Starting G-Code...
[WARNING] Number of paths for which to generate GCode: 6
[DEBUG] Finished G-Code... 6 paths traced.
[DEBUG][Dummy-11] New object with name: copper_l1.gbr_iso_combined_cnc. 0.108721 seconds executing initialize().
[DEBUG] camlib.CNCJob.bounds()
[DEBUG][Dummy-11] Moving new object back to main thread.
[DEBUG][MainThread] on_object_created()
[DEBUG][MainThread] on_object_created --> OC.append()
WARNING: Traceback (most recent call last):
File "/home/adam/Downloads/flatcamBeta/FlatCAM_beta_8.994_sources/appObjects/AppObject.py", line 356, in on_object_created
self.app.collection.append(obj)
File "/home/adam/Downloads/flatcamBeta/FlatCAM_beta_8.994_sources/appObjects/ObjectCollection.py", line 572, in append
obj.set_ui(obj.ui_type(app=self.app))
File "/home/adam/Downloads/flatcamBeta/FlatCAM_beta_8.994_sources/appGUI/ObjectUI.py", line 2488, in __init__
self.jog_step_entry = FCSliderWithDoubleSpinner()
File "/home/adam/Downloads/flatcamBeta/FlatCAM_beta_8.994_sources/appGUI/GUIElements.py", line 1169, in __init__
self.slider.setMaximum(max)
File "/home/adam/Downloads/flatcamBeta/FlatCAM_beta_8.994_sources/appGUI/GUIElements.py", line 1142, in setMaximum
return super(FCDoubleSlider, self).setMaximum(value * self._multi)
TypeError: setMaximum(self, int): argument 1 has unexpected type 'float'
/home/adam/Downloads/flatcamBeta/FlatCAM_beta_8.994_sources/assets/linux/flatcam-beta: line 5: 985825 Aborted (core dumped) python3 $python_script_path/FlatCAM.py $*

Steps to reproduce

beta_8.994
python 3.10
Changes from issue #547

Open project from attachment, on copper layer add isolation routing, with tool diameter 0.3 milling prop. shape V, V-Dia 0.3, V-Angle 20
Generate Geometry
Generate CNCJob Object
*crash*

Solution

change setMinimum, setMaximum, setSingleStep and set_range to pass parameters through int()

‌

[Marius Stanciu]

Those issues are not present when running with Python 3.9 or lower.
Nevertheless, this issue that is seen when run with Python 3.10 is fixed in my working copy and the fix will be in the next release (when released).

[Matti Eiden]

In Py10: There’s also a crash around ToolCutOut.py:263 self.ui.mpass_cb.set_value(float.. results in GuiElements.py:1520 self.setChecked(val) failing with TypeError: setChecked(self, bool): argument 1 has unexpected type 'float' - looks like it works fine if converted to bool instead.

[Marius Stanciu]

Perhaps it can be seen only in Linux, it works fine in Windows (where I am doing my development). I just corrected that anomaly in my latest commit on my Bitbucket repository. Thank you!