Crash when deleting tool in Geometry Object (found a fix!)

Issue #573 new
EOA-electronics created an issue

Hi,
I just discovered another bug. When deleting a tool from the Tools List in an Geometry Object (to load another tool from the Database) FlatCam just crashes.
In the python log I found, that this is due to the “clicked_signal” argument in the “GeometryObject.on_tool_delete()” function. This argument is defined in the function, but when deleting a tool the function seems to be called without specifying the “clicked_signal” argument. (See screenshot1)
As I looked around inside the code of “FlatCAMGeometry.py” for a bit, I found, that this argument isn’t even used anymore, and is just there to prevent other arguments from getting mixed up.

To now fix this, I simply made “clicked_signal” optional, by adding a “=None” in the definition. (See screenshot2)

Please add this fix, or get rid of “_clicked_signal” all together, because it isn_t used anymore and update the source code and the binaries, too.

Thank you very much.
With best regards, Ben.

Comments (0)

  1. Log in to comment