Margin does not have effect on Geometries that are imported in the cutout tool!

Issue #589 resolved
Rami Mehyar created an issue

with the Imported DXF as Gerber you can add a Margin but only in the positive direction!

Comments (13)

  1. Marius Stanciu

    Sorry Rami but I don’t understand. You speak about Cutout Tool and offset but there is no offset functionality in Cutout Tool (plugin). By offset I mean a shift in position on the X-Y plane.
    There is a Margin parameter that will add the cutout a bit further away from the Gerber boundary, are you referring to this as “offset”?

    The Imported DXF as Gerber can be offset but only in the positive direction!

    How do you try to offset (shift position) this? From the Properties of the imported Gerber object or by using the Transformation Plugin?

  2. Rami Mehyar reporter

    Hello Marius,

    Yes, I meant Margin! sorry for the confusion!

    So when you import the Geometry the Margin cannot be added in either direction, but when you add the the .DXF or .SVG as a gerber then you can add a margin but only to the outside!

    It would be nice to be able to cut geometries with Margin in both directions!

    Many thanks,

  3. Rami Mehyar reporter
      <div class="preview-container wiki-content"><!-- loaded via ajax --></div>
      <div class="mask"></div>
    </div>
    

    </div> </form>

  4. Marius Stanciu

    Hi Rami,

    The cutout applied over a Geometry source object was supposed to be in-place (therefore no margin applied) because a Geometry object used here was supposed to be an already made Geometry to fit our needs, so using a Geometry object as a source object is a special case. This is how I made it to work so it is not a bug but simply a limitation.

    Yet, I understand that it can be confusing and I had to make now a choice: either disable the margin parameter when a Geometry object is selected or indeed allow the user to have his way and apply that margin parameter over Geometry objects too.
    Therefore, since it was a bit of work to be done either way, I chose to allow after all the change of margin for the Geometry objects since obviously it will help you.

    For the Gerber objects, when using the positive margin value it is normal to have the Cutout Geometry generated outside of the Gerber object, at a distance (margin + (tooldia/2)). When a negative value is used then the Cutout Geometry is generated inside of the Gerber object yet not ‘inside’ it’s body but imagine a doughnut shape with a hole inside, then this cutout Geometry will be inside the hole of the ‘doughnut-shaped’ Gerber.
    If there are no such holes inside the Gerber or if because the margin + (tooldia/2) is too big to fit such inside Geometry into such a hole then no cutout Geometry should be generated. This is how it works for the Gerber files.
    Like this:

    So, the update is in the latest commit in my working repo: https://bitbucket.org/marius_stanciu/flatcam_beta/branch/Beta_8.995

  5. Rami Mehyar reporter

    Many thanks Marius,

    I guess because I am using Flatcam also for other jobs beside PCB creation, that results in expectations that are not the goal of Flatcam and it’s purpose. Sorry for bugging you guys. Cant wait for the EVO 1.0

  6. Rami Mehyar reporter

    It works like a charm now! In this case, I think there is no need to apply a margin at Gerber files! and you are right with the Donut example-

    Question: How can I help you with the Spanish translation? is there a directory I can get the source texts from?

    Regards,

  7. Marius Stanciu

    In the sources you should have this folder:

    FC_sources_folder\locale\es\LC_MESSAGES
    

    Inside there are 2 files. The strings.mo is not editable and it is automatically generated by the PoEdit open-source software (https://poedit.net/download) after you open/edit/save the strings.po file.

  8. Log in to comment