1. Julien Phalip
  2. pypy
  3. Pull requests

Pull requests

#1 Open
Repository
Branch
popen2-removal
Repository
Branch
default

Use subprocess instead of the deprecated popen2 inside posix.popen(). The 'signal' and 'select' modules are included in the tests as they're imported by subprocess.

Bitbucket cannot automatically merge this request.

The commits that make up this pull request have been removed.

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update 0a4512ee16b3
# Note: This will create a new head!
hg merge 82e23579d3e9
hg commit -m 'Merged in popen2-removal (pull request #1)'
Author
  1. Julien Phalip
Reviewers
Description

This would have the side effect of resolving some test failures in the Django test suite, as those tests rely on os.popen() not generating any error, whereas pypy currently does output warnings to the stderr stream because it imports the deprecated popen2 module.

Comments (0)