Commits

Author Commit Message Labels Comments Date
David G. Andersen
[release-branch.go1] pkg: Removing duplicated words ("of of", etc.), mostly from comments. ««« backport ce3a981ad1ef pkg: Removing duplicated words ("of of", etc.), mostly from comments. Ran 'double.pl' on the pkg tree to identify doubled words. One change to an error string return in x509; the rest are in comments. Thanks to Matt Jibson for the idea. R=golang-dev, bsiegert CC=golang-dev http://codereview.appspot.com/6344089 Committer: Nigel Tao <nigeltao@golang.org> »»»
Branches
release-branch.go1
Matt Jibson
[release-branch.go1] A+C: correct Matt Jibson ««« backport 63dae3ba6a6d A+C: correct Matt Jibson R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/6344088 Committer: David Symonds <dsymonds@golang.org> »»»
Branches
release-branch.go1
Matt Jibson
[release-branch.go1] doc: various "the the" and other typos ««« backport 74c5c02910de doc: various "the the" and other typos R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6355076 Committer: David Symonds <dsymonds@golang.org> »»»
Branches
release-branch.go1
dsymonds
[release-branch.go1] A+C: Matthew Jibson (individual CLA). ««« backport 9349fc3302f5 A+C: Matthew Jibson (individual CLA). R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/6349082 »»»
Branches
release-branch.go1
minux
[release-branch.go1] misc/chrome/gophertool: fix manifest ««« backport 100ddb84c85d misc/chrome/gophertool: fix manifest according to http://code.google.com/chrome/extensions/browserAction.html, it should use "default_popup" instead of "popup". R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6349077 »»»
Branches
release-branch.go1
Robert Griesemer
[release-branch.go1] reflect: reflect.Zero results are neither addressable nor settable ««« backport 21130d62eeb0 reflect: reflect.Zero results are neither addressable nor settable This could be deduced from "The Laws of Reflection" but it seems worthwhile highlighting it. R=r CC=golang-dev http://codereview.appspot.com/6350073 »»»
Branches
release-branch.go1
Rob Pike
[release-branch.go1] encoding/gob: fix bug in Register ««« backport c89f17a9ff4f encoding/gob: fix bug in Register The old code added a star but did not indirect the reflect.Type. R=bradfitz CC=golang-dev http://codereview.appspot.com/6348067 »»»
Branches
release-branch.go1
minux
[release-branch.go1] doc/debugging_with_gdb: mention how to disable gc optimization ««« backport be7e338a8960 doc/debugging_with_gdb: mention how to disable gc optimization R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6353055 »»»
Branches
release-branch.go1
David G. Andersen
[release-branch.go1] math/big: Remove unnecessary test from nat.go multiplication ««« backport c533f48701cb math/big: Remove unnecessary test from nat.go multiplication The switch at the beginning of the function already ensures n > 1, so testing for n < 2 is redundant. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/6350051 Committer: Robert Griesemer <gri@golang.org> »»»
Branches
release-branch.go1
minux
[release-branch.go1] image: fix doc typo ««« backport 042bac4d6b6e image: fix doc typo Fixes issue 3789. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6357058 »»»
Branches
release-branch.go1
minux
[release-branch.go1] cmd/gc: add missing case for OCOM in defaultlit() ««« backport b5c4f411a852 cmd/gc: add missing case for OCOM in defaultlit() Fixes issue 3765. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/6349064 »»»
Branches
release-branch.go1
gluegadget
[release-branch.go1] cmd/go: httpGet function does not use global variable httpClient ««« backport 650544a058e9 cmd/go: httpGet function does not use global variable httpClient No change, just for consistency. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6346048 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Branches
release-branch.go1
Brad Fitzpatrick
[release-branch.go1] net/http: ignore malicious or dumb Range requests ««« backport d32138d8d05f net/http: ignore malicious or dumb Range requests R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6356050 »»»
Branches
release-branch.go1
Pieter Droogendijk
[release-branch.go1] cmd/dist: Make windows.c's fatal() print to stderr ««« backport 3f7501fdb220 cmd/dist: Make windows.c's fatal() print to stderr Generating env.bat using dist env -wp > env.bat failed silently if case of an error, because the message was redirected to env.bat. Verbose messages still go to stdout, causing problems, but that's a seperate change. Made errprintf() identical to xprintf(), except for the output handle. Yes, it's duplicate code, but most…
Branches
release-branch.go1
Jean-Marc Eurin
[release-branch.go1] misc/emacs: Fix the gofmt patching when the TMPDIR is not the default. ««« backport c5f564efc620 misc/emacs: Fix the gofmt patching when the TMPDIR is not the default. The previous code assumed the gofmt output referred to /tmp but that's not true if TMPDIR points somewhere else (like on Macs). Fixes issue 3782. R=sameer CC=golang-dev http://codereview.appspot.com/6346050 Committer: Sameer Ajmani <sameer@golang.org> »»»
Branches
release-branch.go1
Brad Fitzpatrick
[release-branch.go1] net/http: support multiple byte ranges in ServeContent ««« backport 070604630d24 net/http: support multiple byte ranges in ServeContent Fixes issue 3784 R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6351052 »»»
Branches
release-branch.go1
Andrey Mirtchovski
[release-branch.go1] net/http: Fix a verb-tense mismatch and a typo in documentation. ««« backport f8a77e2b7d0b net/http: Fix a verb-tense mismatch and a typo in documentation. R=bradfitz CC=golang-dev http://codereview.appspot.com/6357049 Committer: Brad Fitzpatrick <bradfitz@golang.org> »»»
Branches
release-branch.go1
Robert Griesemer
[release-branch.go1] go spec: clean up section on selectors ««« backport eb24cee7f21b go spec: clean up section on selectors - point out difference between selectors and qualified identifiers - differentiate between illegal selectors and run-time panics - use "indirect" as opposed to "dereference" consistently - add extra links Fixes issue 3779. R=r, rsc, iant, ken CC=golang-dev http://codereview.appspot.com/6326059 »»»
Branches
release-branch.go1
Joseph Poirier
[release-branch.go1] syscall: add missing argument type ««« backport 3909e0071e70 syscall: add missing argument type And update implementation location comment. R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/6352046 »»»
Branches
release-branch.go1
Robert Griesemer
[release-branch.go1] go spec: clean up use of QualifiedIdent production. ««« backport d8bd45866999 go spec: clean up use of QualifiedIdent production. Fixes issue 3763. R=r, rsc, iant, ken CC=golang-dev http://codereview.appspot.com/6333066 »»»
Branches
release-branch.go1
Russ Cox
[release-branch.go1] A+C: L Campbell (individual CLA) ««« backport c88692a626e9 A+C: L Campbell (individual CLA) Guess I was wrong about being done for the day. R=golang-dev, r CC=golang-dev, unpantsu http://codereview.appspot.com/6325060 »»»
Branches
release-branch.go1
Rob Pike
[release-branch.go1] fmt: set p.field before nil check ««« backport 5f13e0662e38 fmt: set p.field before nil check Fixes issue 3752. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6331062 »»»
Branches
release-branch.go1
Andrew Gerrand
[release-branch.go1] doc: drop video title from homepage ««« backport 9da3902443ca doc: drop video title from homepage It's just stutter. R=golang-dev, dsymonds, r CC=golang-dev http://codereview.appspot.com/6334053 »»»
Branches
release-branch.go1
Russ Cox
[release-branch.go1] A+C: Jonathan Gold (individual CLA) ««« backport ee62927ec779 A+C: Jonathan Gold (individual CLA) This is my last one for today, I hope! R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6339052 »»»
Branches
release-branch.go1
Russ Cox
[release-branch.go1] A+C: add Michael Stapelberg (individual CLA) ««« backport 04f61caa80cd A+C: add Michael Stapelberg (individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6325058 »»»
Branches
release-branch.go1
Pieter Droogendijk
[release-branch.go1] go/build: fix doc typo ««« backport e12419d09635 go/build: fix doc typo go/build section "Build Constraints", first paragraph said: "... they must be appear near the top of the file ..." fixed to: "... they must appear near the top of the file ..." R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6329060 Committer: Russ Cox <rsc@golang.org> »»»
Branches
release-branch.go1
gluegadget
[release-branch.go1] misc/chrome/gophertool: Support for manifest version 1 is being phased out. ««« backport 0f017230e6b4 misc/chrome/gophertool: Support for manifest version 1 is being phased out. Manifest version 1 was deprecated in Chrome 18, and support will be phased out according to the schedule available at: http://code.google.com/chrome/extensions/manifestVersion.html R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6332053 Committer: Russ Cox <rsc@golang.org> »»»
Branches
release-branch.go1
Russ Cox
[release-branch.go1] A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA) ««« backport 565770878659 A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA) R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6330059 »»»
Branches
release-branch.go1
Robert Griesemer
[release-branch.go1] spec: clarify receive operator ««« backport c72ac7873261 spec: clarify receive operator - receiving from a closed channel returns immediately - in the ,ok form, the 2nd result is of type bool, not just boolean (gc and ggcgo agree). Per dsymonds' suggestion. R=r, rsc, ken, iant, dsymonds CC=golang-dev http://codereview.appspot.com/6333057 »»»
Branches
release-branch.go1
Russ Cox
[release-branch.go1] runtime: detect hash map collision problems ««« backport f99b9475b914 runtime: detect hash map collision problems This can only happen if the hash function we're using is getting far more than it's fair share of collisions, but that has happened to us repeatedly as we've expanded the allowed use cases for hash tables (issue 1544, issue 2609, issue 2630, issue 2883, issue 3695). Maybe this will help the next time we try something new. R=go…
Branches
release-branch.go1
  1. Prev
  2. Next