Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-04-13 R=dsymonds CC=golang-dev http://codereview.appspot.com/4396047
Tags
weekly.2011-04-13
Russ Cox
runtime: drop chan circular linked list in favor of circular buffer The list elements are already being allocated out of a single memory buffer. We can drop the Link* pointer following and the memory it requires, replacing it with index operations. The change also keeps a channel from containing a pointer back into its own allocation block, which would create a cycle. Blocks involved in cycles are not guaranteed to be finalized properly, and channels depend on …
Russ Cox
pkg: manual cleanup of some gofixed code R=golang-dev, niemeyer, r CC=golang-dev http://codereview.appspot.com/4372052
Russ Cox
gc: fix func syntax error Fixes issue 1685. R=ken2 CC=golang-dev http://codereview.appspot.com/4414042
Corey Thomasson
net: sort records returned by LookupMX R=rog, adg, rsc CC=golang-dev http://codereview.appspot.com/4388048 Committer: Andrew Gerrand <adg@golang.org>
Andrew Gerrand
doc/install.html: document use of libc6-dev-i386 Fixes issue 1689. R=rsc CC=golang-dev http://codereview.appspot.com/4404043
Rob Pike
govet: make name-matching for printf etc. case-insensitive. Update goyacc, cgo to be more canonical in their naming and silence the new warnings. R=rsc, gri CC=golang-dev http://codereview.appspot.com/4417042
Nigel Tao
image: allow "?" wildcards when registering image formats. R=r, nigeltao_gnome CC=golang-dev http://codereview.appspot.com/4404041
Robert Griesemer
gofmt: gofmt -s -w src misc R=r, bradfitzwork CC=golang-dev http://codereview.appspot.com/4406044
Rob Pike
libmach: fix the windows build. Newly enabled compiler errors need workaround. R=rsc CC=golang-dev http://codereview.appspot.com/4397047
Robert Griesemer
fix build: disable gofmt test script, enable gotest testing instead R=rsc CC=golang-dev http://codereview.appspot.com/4403045
Brad Fitzpatrick
http: flesh out server Expect handling + tests This mostly adds Expect 100-continue tests (from the perspective of server correctness) that were missing before. It also fixes a few missing cases that will probably never come up in practice, but it's nice to have handled correctly. Proper 100-continue client support remains a TODO. R=rsc, bradfitzwork CC=golang-dev http://codereview.appspot.com/4399044
Robert Griesemer
gofmt: add test framework in Go - replaced existing testdata/test.sh with new gofmt_test - added initial test case for rewrite tests TODO: Need to add more tests. R=rsc CC=golang-dev http://codereview.appspot.com/4368063
Robert Griesemer
gofmt: minor refactor to permit easy testing R=rsc CC=golang-dev http://codereview.appspot.com/4397046
Russ Cox
reflect: inline method implementations This CL is only cut-and-paste, moving code around. Moving it in a separate CL should simplify the diffs in later CLs. There are three patterns here. 1. A function like func (v Value) M() (...) { return v.panicIfNot(K).(*kValue).M() } becomes func (v Value) M() (...) { vv := v.panicIfNot(K).(*kValue) // body of (*kValue).M, …
Rob Pike
gofix: fix embarrassing typo in osopen.go R=rsc, gri CC=golang-dev http://codereview.appspot.com/4411044
Russ Cox
libmach: fix freebsd compiler errors TBR=r CC=golang-dev http://codereview.appspot.com/4396045
Russ Cox
build: tidy intermediate files during build This CL changes the behavior of 'make install' and 'make test' in the src/cmd directory and the src/pkg directory to have each recursive make clean up after itself immediately. It does the same in test/run, removing $F.$A and $A.out (the common byproducts) between runs. On machines with slow disks and aggressive kernel caching, cleaning up immediately can mean that the intermediate objects never…
Russ Cox
build: use gcc -Werror Better to fix the warnings that we find. R=iant CC=golang-dev http://codereview.appspot.com/4406042
Russ Cox
os/inotify: use _test for test files, not _obj R=golang-dev, r, iant2 CC=golang-dev http://codereview.appspot.com/4408043
Adam Langley
bufio: add ReadLine It matches encoding/line exactly and the tests are copied from there. If we land this, then encoding/line will get marked as deprecated then deleted in time. R=rsc, rog, peterGo CC=golang-dev http://codereview.appspot.com/4389046
Brad Fitzpatrick
io: clarify that ReadAt shouldn't move the seek offset R=r, mkrautz, r2, rsc CC=golang-dev http://codereview.appspot.com/4415041
Robert Griesemer
gofmt: avoid endless loops With the (partial) resolution of identifiers done by the go/parser, ast.Objects point may introduce cycles in the AST. Don't follow *ast.Objects, and replace them with nil instead (they are likely incorrect after a rewrite anyway). - minor manual cleanups after reflect change automatic rewrite - includes fix by rsc related to reflect change Fixes issue 1667. R=rsc CC=golang-dev http://coderevie…
Robert Griesemer
go/ast: fixed bug in NotNilFilter, added test - fixed a couple of comments - cleanups after reflect change R=rsc CC=golang-dev http://codereview.appspot.com/4389041
Andrew Gerrand
builder: fix documentation s/\.gobuilder/.gobuildkey/ R=rsc CC=golang-dev http://codereview.appspot.com/4312051
Dmitry Chestnykh
misc/vim: add plugin with Fmt command. Fmt command filters the current Go buffer through gofmt. It tries to preserve cursor position and avoids replacing the buffer with stderr output. R=golang-dev, dsymonds, niemeyer CC=golang-dev http://codereview.appspot.com/4382053 Committer: David Symonds <dsymonds@golang.org>
dsymonds
archive/tar: fix example's handling of os.EOF. Fixes issue 1677. R=r CC=golang-dev http://codereview.appspot.com/4402042
Gustavo Niemeyer
godashboard: Show packages at launchpad.net The changes were not tested for real in an App Engine environment, so extra care should be taken. That said, some static testing was done with pyflakes, and a few existent problems were fixed on the way. R=adg CC=golang-dev http://codereview.appspot.com/4378053 Committer: Andrew Gerrand <adg@golang.org>
Fazlul Shahriar
os: fix Readdir in Plan 9 'TestReaddir.*' tests now passes. R=golang-dev, lucio, r CC=golang-dev http://codereview.appspot.com/4381048 Committer: Rob Pike <r@golang.org>
Lucio De Re
8l: correct Plan 9 compiler warnings R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4390047 Committer: Russ Cox <rsc@golang.org>
  1. Prev
  2. Next