Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-07-07 R=golang-dev, dsymonds, r CC=golang-dev http://codereview.appspot.com/4668061
Tags
weekly.2011-07-07
Andrew Gerrand
sort: rename helpers: s/Sort// in sort.Sort[Float64s|Ints|Strings] Includes 'sorthelpers' gofix and updates to tree. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4631098
dsymonds
gob: export fields in structs in the package documentation. R=r CC=golang-dev http://codereview.appspot.com/4648075
Brad Fitzpatrick
cgi: don't depend on CGI.pm for tests CGI.pm used to be part of the Perl core, but some distros now bundle perl-core and perl-modules separately. It's not worth depending on. R=golang-dev, mattn.jp CC=golang-dev http://codereview.appspot.com/4675063
Nigel Tao
image/draw: add draw tests where the destination image doesn't start at (0, 0). Also refactor the test to use the SubImage method rather than monkeying with an image's Pix and Rect fields. R=r CC=golang-dev http://codereview.appspot.com/4678045
Adam Langley
crypto/x509: prevent chain cycles in Verify It's possible to include a self-signed root certificate as an intermediate and push Verify into a loop. I already had a test for this so I thought that it was ok, but it turns out that the test was void because the Verisign root certificate doesn't contain the "IsCA" flag and so it wasn't an acceptable intermediate certificate for that reason. R=bradfitz CC=golang-dev http://codereview.appspot.c…
Brad Fitzpatrick
doc: remove ed from apt-get package list R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4672052
Nigel Tao
image: tighten Paletted.Opaque to check only those palette entries in the image, not all palette entries. R=r CC=golang-dev http://codereview.appspot.com/4672049
Rob Pike
os: fix documentation for FileInfo.Name. It's the base name, not the full name. Fixes issue 2047. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4680041
Rob Pike
exp/template: handle pointers and values in empty interfaces. R=golang-dev, r, mattn.jp CC=golang-dev http://codereview.appspot.com/4664064
Rob Pike
exp/template: change the name from 'metacharacter' to 'delimiter', because that's what they are. No semantic change. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4675060
Gideon Redelinghuys
crypto/openpgp: fixed dangerous use of for loop variable In function readSignedMessage a pointer to for loop variable 'key' was incorrectly being assigned to md.SignedBy. Changed so that md.SignedBy is pointing to the 'more correct' memory position. R=golang-dev, r, agl CC=golang-dev http://codereview.appspot.com/4631088 Committer: Rob Pike <r@golang.org>
Rob Pike
C+A: Gideon Jan-Wessel Redelinghuys R=golang-dev, dsymonds CC=gjredelinghuys, golang-dev http://codereview.appspot.com/4675059
brainman
syscall: rearrange windows code so 386 and amd64 can share files R=golang-dev, r CC=golang-dev, vcc.163 http://codereview.appspot.com/4641093
Rob Pike
CONTRIBUTORS: add Google contributor mpvl@golang.org R=golang-dev, dsymonds CC=golang-dev, mpvl http://codereview.appspot.com/4643075
Rob Pike
exp/template: index: forgot the always last-to-arrive uintptr. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4636087
Adam Langley
asn1: support T61 and UTF8 string. There is no end to the kitchen sink of string types in ASN.1. Fixes issue 1953. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4672045
Adam Langley
crypto/tls: fix generate_cert.go Fixes issue 2030. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4635092
Ian Lance Taylor
json: fix test if rand returns 0. Fixes test when run with gccgo using optimization, which changes the order of the calls to rand. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4639101
Rob Pike
exp/template: index function for arrays, slices, and maps. R=golang-dev, adg, r CC=golang-dev http://codereview.appspot.com/4643072
Rob Pike
exp/template: silence test noise (but add a flag to put it back) Also delete a TODO and clean up a little evaluation code. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4643071
dsymonds
exp/template: add a JavaScript escaper. R=r CC=golang-dev http://codereview.appspot.com/4671048
Rob Pike
exp/template: allow an empty interface value to be the target of range, etc. We extract the concrete value inside. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4677041
Rob Pike
exp/template: improve error message for non-exported field. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4636086
Rob Pike
maketables: update debugging data. This is unused in the generation of the tables, but was incorrect if we ever needed it. Also update the reference to the document. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4626097
dsymonds
exp/template: add missing dotNode case. R=r CC=golang-dev http://codereview.appspot.com/4672044
Rob Pike
exp/template: fixes and updates. - fix line numbers - forgot to update state.line during execution - add a comment convention {{/* comment */}} - set.Template returns the named template in the set - set.Execute executes the named template in the set - use a local methodByName so this package can be used with earlier release of reflect. - use initial cap to detect exported names R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4668054
dsymonds
exp/template: remove debugging dreg. R=r, gri TBR=r CC=golang-dev http://codereview.appspot.com/4671047
Yasuhiro Matsumoto
html: parse start tags that aren't explicitly otherwise dealt with. R=golang-dev, nigeltao CC=golang-dev http://codereview.appspot.com/4626080 Committer: Nigel Tao <nigeltao@golang.org>
Rob Pike
exp/template: remove the need for a goroutine. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4626095
  1. Prev
  2. Next