Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
weekly.2011-08-17 R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4914042
Tags
weekly.2011-08-17
Rob Pike
gofix: walk names in ValueSpecs R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4887048
Rob Pike
test/chan/select5.go: change "with" to "if" in templatea I converted this program yesterday and the output is the same as it used to be, ignoring space, but the result is not the best expression of the algorithm. The old {.section Maybe} pieces are now {{with .Maybe}}, as a direct translation, but I they should be {{if .Maybe}} as the output is just a bool and there is no cascading. I have verified that the output of the program is unaffected. R=gola…
Yasuhiro Matsumoto
misc/vim: command complete using autoload helper function. R=golang-dev, dsymonds, jnwhiteh, n13m3y3r, gustavo CC=golang-dev http://codereview.appspot.com/4837051 Committer: David Symonds <dsymonds@golang.org>
Rob Pike
http: remove a TODO due to new behavior of nil maps R=golang-dev, dsymonds, adg CC=golang-dev http://codereview.appspot.com/4907049
Mike Samuel
exp/template/html: defines a parse context for a subset of HTML. This defines just enough context to distinguish HTML URI attributes from parsed character data. It does not affect any public module API as I thought I would get early comment on style for defining enumerations and tables. R=rsc, r, nigeltao, r CC=golang-dev http://codereview.appspot.com/4906043 Committer: Rob Pike <r@golang.org>
Andrew Gerrand
doc/codelab: use new template package R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4897048
Robert Griesemer
godoc: template cleanup Use naming convention for template variables to indicate "escaped-ness" for easier reviewing. (per suggestion from bradfitz) R=bradfitz CC=golang-dev http://codereview.appspot.com/4914041
Russ Cox
test: new nil semantics R=gri CC=golang-dev http://codereview.appspot.com/4644052
Russ Cox
gc: implement nil chan support The spec has defined nil chans this way for months. I'm behind. R=ken2 CC=golang-dev http://codereview.appspot.com/4897050
Russ Cox
gc: implement nil map support The spec has defined nil maps this way for months. I'm behind. R=ken2 CC=golang-dev http://codereview.appspot.com/4901052
Russ Cox
gc: fix mkbuiltin Broken by Plan 9 changes. R=ken2 CC=golang-dev http://codereview.appspot.com/4896050
Robert Griesemer
go/parser: disallow for statements w/ illegal range clauses R=rsc CC=golang-dev http://codereview.appspot.com/4908047
Fazlul Shahriar
net: Plan 9 support All tests enabled by default passes except those in timeout_test.go. For TestLookupPort, add an entry for "bootps" in /lib/ndb/common (Plan 9 calls it "bootp"). I've sent out a patch to fix this. R=paulzhol, rsc, mikioh.mikioh CC=ality, golang-dev http://codereview.appspot.com/4779041 Committer: Russ Cox <rsc@golang.org>
Robert Griesemer
go/parser: do not accept type literals where not permitted in general - Resolves a long-standing TODO. - Replacement for CL 4908042 by befelemepeseveze@gmail.com Fixes issue 2155. R=rsc CC=golang-dev http://codereview.appspot.com/4904048
kylelemons
xml: escape string chardata in xml.Marshal Fixes issue 2150. R=golang-dev, nigeltao, rsc CC=golang-dev http://codereview.appspot.com/4890042 Committer: Russ Cox <rsc@golang.org>
Dave Cheney
asn1: add support for unmarshalling structs with int32 members Also improve error message for unsupported integer types R=agl, rsc CC=golang-dev http://codereview.appspot.com/4873049 Committer: Russ Cox <rsc@golang.org>
Marcel van Lohuizen
exp/norm: implementation of decomposition and composing functionality. forminfo.go: - Wrappers for table data. - Per Form dispatch table. composition.go: - reorderBuffer type. Implements decomposition, reordering, and composition. - Note: decompose and decomposeString fields in formInfo could be replaced by a pointer to the trie for the respective form. The proposed design makes testing easier, though. normalization.go: - Temporarily added panic("not implemented") methods to make the tests run. These will be removed again with the next CL, which will introduce the implementation. R=r, rogpeppe, mpvl, rsc CC=golang-dev http://codereview.appspot.com/4875043 Committer: Rob Pike <r@golang.org>
Rob Pike
test/chan/select5.go: update to new templates R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4911041
Mike Samuel
exp/template/html: rework Reverse(*Template) to do naive autoescaping Replaces the toy func Reverse(*Template) with one that implements naive autoescaping. Now Escape(*Template) walks a template parse tree to find all template actions and adds the |html command to them if it is not already present. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4867049 Committer: Rob Pike <r@golang.org>
Andrew Gerrand
doc/codewalk: new Markov chain codewalk R=gri, r, rsc CC=golang-dev http://codereview.appspot.com/4891041
Rob Pike
template: move exp/template into template. (Leave exp/template/html where it is for now.) R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4899048
Rob Pike
template: delete old template code. It's already in old/template; make that build. Update a couple of references to point to the old template. They can be updated later. Update goplay to use exp/template. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4902046
Rob Pike
misc: fix a couple of template uses preparatory to the big switch. R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/4876057
Rob Pike
url: new package This is just moving the URL code from package http into its own package, which has been planned for a while. Besides clarity, this also breaks a nascent dependency cycle the new template package was about to introduce. Add a gofix module, url, and use it to generate changes outside http and url. Sadness about the churn, gladness about some of the naming improvements. R=dsymonds, bradfitz, rsc, gustavo, r CC=golang-dev http://codereview.appspot.com/4893043
Aleksandar Dezelin
net: Added function SetTimeout() to interface Listener. Fixes issue 2148. R=golang-dev, bradfitz, rsc CC=golang-dev http://codereview.appspot.com/4905042 Committer: Russ Cox <rsc@golang.org>
Robert Griesemer
go/parser: use correct precedence when parsing range clauses Fixes issue 2156. R=rsc CC=golang-dev http://codereview.appspot.com/4899046
Russ Cox
A+C: Aleksandar Dezelin (individual CLA) R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4901047
Joel Sing
net: add multicast stubs for openbsd Add multicast stubs and sync with recent changes. R=golang-dev, mikioh.mikioh CC=golang-dev http://codereview.appspot.com/4838058 Committer: Russ Cox <rsc@golang.org>
Joel Sing
net, syscall: move multicast address handling Multicast address handling is not consistent across all BSDs. Move the multicast address handling code into OS dependent files. This will be needed for OpenBSD support. R=mikioh.mikioh, golang-dev CC=golang-dev http://codereview.appspot.com/4809074 Committer: Russ Cox <rsc@golang.org>
  1. Prev
  2. Next