Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
doc: fix weekly.2011-12-06 release notes typo R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5453072
Tags
weekly.2011-12-06
Andrew Gerrand
tag weekly.2011-12-06 R=r CC=golang-dev http://codereview.appspot.com/5440125
Andrew Gerrand
weekly.2011-12-06 R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5453070
Brad Fitzpatrick
http: make Transport warning about connections closing more accurate It was fragile and non-portable, and then became spammy with the os.EINVAL removal. Now it just uses the length of the Peek return value instead. R=golang-dev, alex.brainman CC=golang-dev http://codereview.appspot.com/5453065
Adam Langley
crypto: allocate less. The code in hash functions themselves could write directly into the output buffer for a savings of about 50ns. But it's a little ugly so I wasted a copy. R=bradfitz CC=golang-dev http://codereview.appspot.com/5440111
Dave Cheney
exp/ssh: cleanup client auth tests This CL cleans up the client auth tests, making the individual test body more manageable. Also, adds tests for rsa and dsa key negotiation. Finally, remove the package level use of the variable strings, which avoids conflicting with the strings pkg. R=gustav.paul, agl, n13m3y3r, rsc CC=golang-dev http://codereview.appspot.com/5447049 Committer: Adam Langley <agl@golang.org>
Andrew Gerrand
goinstall: honour -install=false flag when -make=true R=rsc CC=golang-dev http://codereview.appspot.com/5448124
Robert Griesemer
strconv: squeezed a bit more out of int/uint formatting - less code - slightly better performance (0-4%) R=r, rsc CC=golang-dev http://codereview.appspot.com/5448120
Adam Langley
crypto/x509: if a parent cert has a raw subject, use it. This avoids a problem when creating certificates with parents that were produce by other code: the Go structures don't contain all the information about the various ASN.1 string types etc and so that information would otherwise be lost. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5453067
Rob Pike
html/template: simplify ExecuteTemplate a little Allow the text template to handle the error case of no template with the given name. Simplification suggested by Mike Samuel. R=mikesamuel CC=golang-dev http://codereview.appspot.com/5437147
Rob Pike
fmt: benchmark floating point. mallocs per Sprintf("%x"): 1 mallocs per Sprintf("%g"): 4 R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5449106
Maxim Pimenov
cgo: fix typo in the documentation R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5448115 Committer: Robert Griesemer <gri@golang.org>
Robert Griesemer
strconv: 34% to 63% faster conversions (Note that the Int and Uint benchmarks use different test sets and thus cannot be compared against each other. Int and Uint conversions are approximately the same speed). Before (best of 3 runs): strconv_test.BenchmarkFormatInt 100000 15636 ns/op strconv_test.BenchmarkAppendInt 100000 18930 ns/op strconv_test.BenchmarkFormatUint 500000 4392 ns/op strconv_test.BenchmarkAppendUint…
Russ Cox
gc: disallow map/func equality via interface comparison Missed when I removed direct map/func equality. R=ken2 CC=golang-dev http://codereview.appspot.com/5452052
Russ Cox
image: avoid func comparison during ColorModel comparison When I disallowed map + func comparisons, I only did it in the static case and missed the comparisons via == on interface values. Fixing that turned these up. R=nigeltao, r CC=golang-dev http://codereview.appspot.com/5440103
Dave Cheney
exp/ssh: simplify client channel open logic This is part one of a small set of CL's that aim to resolve the outstanding TODOs relating to channel close and blocking behavior. Firstly, the hairy handling of assigning the peersId is now done in one place. The cost of this change is the slightly paradoxical construction of the partially created clientChan. Secondly, by creating clientChan.stdin/out/err when the channel is opened, the creatio…
Rob Pike
various: we don't cast, we convert R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5437142
Andrew Gerrand
hash: rewrite comment on Hash.Sum method Fixes issue 2530. R=golang-dev, agl CC=golang-dev http://codereview.appspot.com/5449101
Rob Pike
fmt: only use Stringer or Error for strings This is a slight change to fmt's semantics, but means that if you use %d to print an integer with a Stringable value, it will print as an integer. This came up because Time.Month() couldn't cleanly print as an integer rather than a name. Using %d on Stringables is silly anyway, so there should be no effect outside the fmt tests. As a mild bonus, certain recursive failures of String methods will also be avoided this way. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5453053
Volker Dobler
godoc: Show type examples between variables and methods. Fixes issue 2466. R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5451094 Committer: Andrew Gerrand <adg@golang.org>
Russ Cox
gofix: fix for strconv API change R=golang-dev, gri, adg, r CC=golang-dev http://codereview.appspot.com/5434098
Russ Cox
use new strconv API All but 3 cases (in gcimporter.go and hixie.go) are automatic conversions using gofix. No attempt is made to use the new Append functions even though there are definitely opportunities. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5447069
Russ Cox
strconv: new API R=golang-dev, bradfitz, gri, r, agl CC=golang-dev http://codereview.appspot.com/5434095
Luuk van Dijk
gc: changes in export format in preparation of inlining. Includes minimal change to gcimporter to keep it working, R=rsc, gri CC=golang-dev http://codereview.appspot.com/5431046 Committer: Russ Cox <rsc@golang.org>
Russ Cox
gc: remove type elision in struct literals R=ken2 CC=golang-dev http://codereview.appspot.com/5437136
Russ Cox
spec: remove contentious composite literal shortening R=gri, r, gustavo, r CC=golang-dev http://codereview.appspot.com/5451099
Charles L. Dorian
math: add special-cases comments to Sinh and Tanh. Also change "Special conditions" to "Special cases" as in other functions. R=rsc, golang-dev CC=golang-dev http://codereview.appspot.com/5440078 Committer: Russ Cox <rsc@golang.org>
Rémy Oudompheng
crypto/aes: eliminate some bounds checking and manual truncation. By converting array indices to uint8, they are automatically constrained in the array range, and the binary AND with 0xff is no longer needed anymore. Before: aes.BenchmarkEncrypt 363 ns/op After: aes.BenchmarkEncrypt 273 ns/op R=golang-dev, gri, agl CC=golang-dev, remy http://codereview.appspot.com/5450084 Committer: Adam Langley <agl@golang.org>
Russ Cox
runtime: prep for type-specific algorithms Equality on structs will require arbitrary code for type equality, so change algorithm in type data from uint8 to table pointer. In the process, trim top-level map structure from 104/80 bytes (64-bit/32-bit) to 24/12. Equality on structs will require being able to call code generated by the Go compiler, and C code has no way to access Go return values, so change the hash and equal algorithm funct…
Andrew Gerrand
gobuilder: use new dashboard protocol gobuilder: -commit mode for packages gobuilder: cripple -package mode temporarily R=golang-dev, dsymonds CC=golang-dev http://codereview.appspot.com/5450092
  1. Prev
  2. Next