Commits

Show all
Author Commit Message Labels Comments Date
Andrew Gerrand
release.2011-02-24 R=r, rsc CC=golang-dev http://codereview.appspot.com/4213044
Tags
weekly.2011-02-24
Branches
default
Adam Langley
crypto/openpgp: add package R=bradfitzgo CC=golang-dev http://codereview.appspot.com/3989052
Branches
default
Robert Griesemer
godoc: accept symbolic links as path names provided to -path When providing addition file systems to godoc via -path, the path names may be symbolic links. Follow them. Also: better logging of error and special conditions. R=r, dsymonds, r2 CC=golang-dev http://codereview.appspot.com/4217045
Branches
default
brainman
runtime: add empty windows/signals.h file to fix build R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4223049
Branches
default
Nigel Tao
compress/lzw: implement an encoder. R=rsc, nigeltao_gnome CC=golang-dev http://codereview.appspot.com/4209043
Branches
default
Russ Cox
reflect: add pointer word to CommonType The pointer will eventually let us find *T given T. This CL just makes room for it, always storing a zero. R=r, r2 CC=golang-dev http://codereview.appspot.com/4221046
Branches
default
Russ Cox
runtime: fix signal stack bug In CL 4188061 I changed malg to allocate the requested number of bytes n, not n+StackGuard, so that the allocations would use rounder numbers. The allocation of the signal stack asks for 32k and then used g->stackguard as the base, but g->stackguard is StackGuard bytes above the base. Previously, asking for 32k meant getting 32k+StackGuard bytes, so using g->stackguard as the base was safe. Now…
Branches
default
Russ Cox
ld: weak symbols A reference to the address of weak.foo resolves at link time to the address of the symbol foo if foo would end up in the binary anyway, or to zero if foo would not be in the binary. For example: int xxx = 1; int yyy = 2; int weak·xxx; int weak·yyy; void main·main(void) { runtime·printf("%p %p %p\n", &xxx, &weak·xxx, &weak·yyy); } …
Branches
default
Russ Cox
http: remove debugging log statement Issue 1547 is fixed. R=bradfitzgo, r CC=golang-dev http://codereview.appspot.com/4209045
Branches
default
Robert Griesemer
godoc: fix writeFileAtomically utility function If the filename was absolute, writeFileAtomically used the wrong filename for ioutil.TempFile leading to non-existent directories and the TempFile would fail. R=r, r2 CC=golang-dev http://codereview.appspot.com/4224043
Branches
default
Robert Griesemer
godoc: log errors when reading filter files R=r, r2 CC=golang-dev http://codereview.appspot.com/4230042
Branches
default
Rob Pike
fmt: stop giving characters to the Scan method of Scanner when we hit a newline during *scanln routines. Fixes issue 1490. R=rsc CC=golang-dev http://codereview.appspot.com/4209042
Branches
default
brainman
8l/6l: new -Hwindowsgui flag allows to build windows gui pe Fixes issue 1516. R=rsc, mattn CC=golang-dev http://codereview.appspot.com/4214041
Branches
default
Dave Cheney
build: remove unused nacl conditional from make.bash R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4217042 Committer: Andrew Gerrand <adg@golang.org>
Branches
default
brainman
net: *netFD.Read to return os.EOF on eof (fixes windows build) R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4210041
Branches
default
Brad Fitzpatrick
http: set method GET on Get() requests R=adg, bradfitzwork CC=golang-dev http://codereview.appspot.com/4229042 Committer: Brad Fitzpatrick <bradfitz@golang.org>
Branches
default
Russ Cox
build: remove _gcc_main.c during make clean R=r, r2 CC=golang-dev http://codereview.appspot.com/4226043
Branches
default
Russ Cox
runtime: always run stackalloc on scheduler stack Avoids deadlocks like the one below, in which a stack split happened in order to call lock(&stacks), but then the stack unsplit cannot run because stacks is now locked. The only code calling stackalloc that wasn't on a scheduler stack already was malg, which creates a new goroutine. runtime.futex+0x23 /home/rsc/g/go/src/pkg/runtime/linux/amd64/sys.s:139 runtime.futex() futexsleep+0x50 /ho…
Branches
default
Russ Cox
runtime: omit breakpoint during terminal panic A terminal panic (one that prints a stack trace and exits) has been calling runtime.breakpoint before calling exit, so that if running under a debugger, the debugger can take control. When not running under a debugger, though, this causes an additional SIGTRAP on Unix and pop-up dialogs on Windows. Support for debugging Go programs has gotten good enough that we can rely on the debugger to set i…
Branches
default
Brad Fitzpatrick
http: introduce start of Client and ClientTransport Much yet to come, but this is a safe first step, introducing an in-the-future configurable Client object (where policy for cookies, auth, redirects will live) as well as introducing a ClientTransport interface for sending requests. The CL intentionally ignores everything around the creation and configuration of Clients and merely ports/wraps the old interfaces to/around Client/ClientTransport. R…
Branches
default
Russ Cox
runtime: pass to signal handler value of g at time of signal The existing code assumed that signals only arrived while executing on the goroutine stack (g == m->curg), not while executing on the scheduler stack (g == m->g0). Most of the signal handling trampolines correctly saved and restored g already, but the sighandler C code did not have access to it. Some rewriting of assembly to make the various implementations as similar as possible. Will need to …
Branches
default
Russ Cox
runtime: traceback through active lessstack With this change, a panic trace due to a signal arriving while running on the scheduler stack during a lessstack (a stack unsplit) will trace through the lessstack to show the state of the goroutine that was unsplitting its stack. R=r CC=golang-dev http://codereview.appspot.com/4206042
Branches
default
Russ Cox
5g: fix optimizer bug same as in issue below, never fixed on ARM changeset: 5498:3fa1372ca694 user: Ken Thompson <ken@golang.org> date: Thu May 20 17:31:28 2010 -0700 description: fix issue 798 cannot allocate an audomatic temp while real registers are allocated. there is a chance that the automatic will be allocated to one of the allocated registers. the fix is to not registerize such variables. R=r…
Branches
default
Robert Griesemer
sync: make package comment appear R=rsc CC=golang-dev http://codereview.appspot.com/4220044
Branches
default
Rob Pike
gob: protect against pure recursive types. There are further changes required for things like recursive map types. Recursive struct types work but the mechanism needs generalization. The case handled in this CL is pathological since it cannot be represented at all by gob, so it should be handled separately. (Prior to this CL, encode would recur forever.) R=rsc CC=golang-dev http://codereview.appspot.com/4206041
Branches
default
Adam Langley
compress/bzip2: fix bugs (Once again, proving that a fuzz tester is the first thing that I should try.) R=bradfitzgo CC=golang-dev http://codereview.appspot.com/4227042
Branches
default
Gustavo Niemeyer
codereview: fix clpatch with empty diffs Avoid passing the placeholder diff to hgpatch, so that clpatch-ing an empty diff grabs the metadata and warns about it being empty, rather than failing with a hard-to-debug problem ("mkdir: no such file or dir", no metadata, etc). R=rsc CC=golang-dev http://codereview.appspot.com/4172060 Committer: Russ Cox <rsc@golang.org>
Branches
default
rogpeppe
json: use base64 to encode []byte R=rsc CC=golang-dev http://codereview.appspot.com/4160058 Committer: Russ Cox <rsc@golang.org>
Branches
default
Adam Langley
compress/bzip2: add package. This code implements bzip2 decompression only. R=bradfitzgo, r2, nigeltao, rsc CC=golang-dev http://codereview.appspot.com/4176051
Branches
default
Nigel Tao
compress/lzw: implement a decoder. R=rsc CC=bsiegert, golang-dev, mpl http://codereview.appspot.com/4182081
Branches
default
  1. Prev
  2. Next