Issues with ENABLE_DELETE & "Data Officer" in general

[Mindbender666]

Hi!

Environment

• Ubuntu 18.04 LTS (lxc container)
• piler 1.3.7 compiled from source

Description

Sorry… it’s actually two - more or less - non-related issues.
I just stumbled across them while testing out the delete feature.

#Deletion of emails

When I enable ENABLE_DELETE the Auditor can select Emails for deletion from the Gui/Search dialog. On clicking the delete button a dialog (“reason of removal”) pops up. Upon entering a reason and clicking OK nothing else seem to happen. No MySQL query is logged (general log enabled) and no message is logged by piler ($config['LOG_LEVEL'] = DEBUG;) as well.

#Data officer

• The “Data Officer” starts with the view route=audit/removal. In the menu there is only an option to change to search.php but not an option to get back to the “audit/removal” view.
• Since ENABLE_DELETE does not seem to work properly in my setup the “audit/removal” view is always empty for the “Data Officer” - even when setting NEED_TO_APPROVE_DELETE=1.

‌

[Janos SUTO]

I’ll checkout this issue soon, and let you know.

[Janos SUTO]

Sorry, that it took quite some time to check this issue. Anyway it works properly for me.

When you enable ENABLE_DELETE, and as an auditor delete them on the gui, then in the background they are marked for removal. If you hit the search button again, then they should be grayed out as a visual clue for that. Then when purge.sh runs from piler’s crontab, then the messages will be effectively removed from the archive. So check if you run purge.sh periodically. Also if purging is enabled on the gui. The data officer can only see emails at audit/removal if NEED_TO_APPROVE_DELETE=1 Otherwise an auditor can delete email without any further approval.

However, you are right the upper left icon should link to audit/removal, and not to search. Perhaps it should be titled with “home”. I’ll fix it soon.

[Mindbender666]

#Deletion of emails

That was actually a f*** up on my end. I wasn’t aware that selecting an email (=clicking on it;showing the contents) wasn’t sufficient, but that the checkboxes have to be selected instead.

Since there is no feedback at all, I thought it was an error and didn’t make the connection to the checkboxes.
Probably a popup like “no email selected” would a an appropiate clue, instead of the default “reason of removal” popup.

‌

[Janos SUTO]

I got your point, I’ll improve the gui to print a warning message if 0 email is selected.

[Janos SUTO]

The head of the master branch has the warning message if you don't select any message.