pilerimport skiplist skips my inbox

Our IMAP server names our mailboxes like this:

INBOX (Main inbox) INBOX.Drafts INBOX.spam INBOX.Junk INBOX.Trash

etc.

If I run pilerimport with the following command line:

$ pilerimport -I myimapserver -u my@email.com -p mypassword -s INBOX,spam,INBOX.Junk,INBOX.Trash,INBOX.Drafts

It will also skip my "INBOX" because the strstr() function finds "INBOX" in the skiplist.

Maybe we could rename our main inbox to something like INBOX.Inbox to eliminate the issue, but (a) I'm not sure how to do that for everyone automatically when we create a new user's email account; and (b) I don't want to because I'm worried about side-effects that I can't predict.

I wanted to suggest a different method for determining of a mailbox folder should be skipped, below. I have not been a C programmer for many, many years so I am prepared for folks to snicker at my example, but, in testing here, it solves my problem. (I used different return values explaining why the function thinks the folder should be skipped to help in debugging.)

I thought of other ways to do it, but I wanted to suggest something that would be least invasive to the program as it stands today. For example, I thought about preparing the skiplist into an array and then looking for the candidate folder in the array. But that would have required more changes to the pilerimport program than I wanted to test. This just required the addition of a new function and changing one line of code in the imap import function.

/*
 * RETURNS:
 *   0 . . . Folder is NOT in the skiplist
 *   1 . . . Folder name was found at the BEGINNING of the skiplist
 *   2 . . . Folder is the ONLY item in the skiplist
 *   3 . . . Folder is in the MIDDLE of the skiplist
 *   4 . . . Folder is at the END of the skiplist
 */
int should_skip_folder(char *folder, char *skiplist)
{
  char *with_comma;

  //Is folder at the beginning of thte list?
  if ((with_comma = malloc(strlen(folder)+2)) != NULL) {
    with_comma[0] = '\0';
    strcat(with_comma, folder);
    strcat(with_comma, ",");
    if (strncmp(skiplist, with_comma, strlen(with_comma)) == 0) return 1;
  } else {
    fprintf(stderr, "100 - malloc failed\n");
    return 0;
  }

  //Is folder the ONLY folder in the list?
  if (strcmp(folder, skiplist) == 0) return 2;

  //Is folder in the middle of the list?
  if ((with_comma = malloc(strlen(folder)+3)) != NULL) {
    with_comma[0] = '\0';
    strcat(with_comma, ",");
    strcat(with_comma, folder);
    strcat(with_comma, ",");
    if (strstr(skiplist, with_comma)) return 3;
  } else {
    fprintf(stderr, "101 - malloc failed\n");
    return 0;
  }

  //Is folder at the END of the list?
  int slen = strlen(skiplist);
  int flen = strlen(folder);
  if (strcmp(skiplist+slen-flen, folder) == 0) return 4;

  return 0;
}

Comments (8)