envelope from characters

[s s]

Hi

We have piler 0.1.25-master-branch, build 857. I know this is outdated release and this issue may be resolved. I found that when was looking for some bulk messages in archive. Let me explain what i've found.

When a sender have these special characters: ['] or [&] then piler do not save full local part to the mysql db exim log:

2014-11-22 14:14:35 [31623] 1XsBSN-0008E2-HO => [e-mail] F=<TEST'[e-mail]> P=<TEST'[e-mail]> R=route_archive T=remote_smtp S=965 H=X.X.X.X:25 C="250 Ok 4000000054709a5529f6ce3400a5c59bccf9 <[e-mail]>" QT=0s DT=0s

piler maillog

Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: sent: 220 server.domain.com ESMTP#015
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: got: EHLO server.domain.com
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: sent: 250-server.domain.com#015#012250-PIPELINING#015#012250-SIZE#015#012250 8BITMIME#015
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: got: MAIL FROM:<TEST'[e-mail]> SIZE=2024
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: got: RCPT TO:<[e-mail]>
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: got: DATA
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: sent: 250 Ok#015#012250 Ok#015#012354 Send mail data; end it with <CRLF>.<CRLF>#015
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: period found
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: got: (.)
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: parsed message
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: hdr_len: 954, offset: 3
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: round 0 in injection
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: processing message
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: stored '4000000054709a5529f6ce3400a5c59bccf9.m' 960/666 bytes
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: added 1 recipients
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: stored recipients, rc=0
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: stored indexdata, rc=0
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: stored metadata, rc=0
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: sent: 250 Ok 4000000054709a5529f6ce3400a5c59bccf9 <[e-mail]>#015
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: from=TEST'[e-mail], size=960, attachments=0, reference=, message-id=<[e-mail]>, retention=395, delay=0.00, delays=0.00/0.00/0.00/0.00/0.00/0.00, status=stored
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: got: QUIT
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: removed
Nov 22 14:14:35 server piler[5570]: 4000000054709a5529f6ce3400a5c59bccf9: sent: 221 server.domain.com Goodbye#015

mysql search

SELECT `from` FROM `v_messages` WHERE `piler_id` = '4000000054709a5529f6ce3400a5c59bccf9'

result is '[e-mail]'. The 'TEST' part is missing.

Also it seems that these characters are allowed. http://www.remote.org/jochen/mail/info/chars.html

Thanks.

[Janos SUTO]

The link you provided said that ' and & may be usable in email addresses. Anyway the parser rewrites them that's why you get only [e-mail].

[s s]

Postfix and exim allow such local parts. Can you add support for them in piler?

[Janos SUTO]

Try the following: edit src/parser_utils.c, and locate function translateLine(), and replace the following line

if( (state->message_state == MSG_FROM || state->message_state == MSG_TO || state->message_state == MSG_CC || state->message_state == MSG_RECIPIENT) && *p == '_'){ continue; }

with this:

if( (state->message_state == MSG_FROM || state->message_state == MSG_TO || state->message_state == MSG_CC || state->message_state == MSG_RECIPIENT) && (*p == '_' || *p == '\'' || *p == '&') ){ continue; }

Then recompile, and check if it works.

[Janos SUTO]

Just commited to the master branch, please test it.