subject repeated on reply / forward

Issue #527 resolved
Dr Evil created an issue

Archivied messages that got an reply or got forwarded display the subject multiple times. Is that a configurable feature or a bug?

Here a screenshot Screenshot_Subject.png

Seems that the subjects are already messed up in metadata

mysql> select id,subject from metadata where subject like '%DELFZIJL%';
+------+-------------------------------------------------------------------------+
| id   | subject                                                                 |
+------+-------------------------------------------------------------------------+
| 2089 | DELFZIJL                                                                |
| 2107 | RE: DELFZIJLSubject: DELFZIJL                                           |
| 3076 | FW: DELFZIJLSubject: RE: DELFZIJLSubject: DELFZIJL                      |
| 3115 | RE: DELFZIJLSubject: RE: DELFZIJLSubject: DELFZIJL                      |
| 3321 | RE: DELFZIJLSubject: FW: DELFZIJLSubject: RE: DELFZIJLSubject: DELFZIJL |
+------+-------------------------------------------------------------------------+

Versioninfo

piler 1.2.0, build 909, Janos SUTO sj@acts.hu

Build Date: Wed Mar 18 12:17:33 CET 2015 ldd version: ldd (Debian EGLIBC 2.13-38+deb7u8) 2.13 gcc version: gcc version 4.7.2 (Debian 4.7.2-5) Configure command: ./configure --localstatedir=/var --with-database=mysql --enable-starttls --enable-tcpwrappers

Comments (7)

  1. Janos SUTO repo owner

    It's odd, I've never seen anything like this. Can you show me the headers for these 5 messages. Please send them to me privately in a zip file.

  2. Marnus van Wyk

    Afternoon

    I have exactly the same issue on "some" emails, was just about to post a question but i thought maybe looking through the previous posts and it looks identical

    What is the patch? I'm on version 1.1.1, i've seen it since the beginning, i had to do a kernel update at some point for a VM backup problem, that updated sphinx as well i believe and it is definitely still happening

    archiver_error1.png

    what is interesting, it detects a conversation, and then it starts dumping the conversation subjects in the first email subject.. this shows it well.

    archiver_error2.png

    What is definitely problematic is that it doesn't always do that, it would take messages not even close to conversations and concating their subjects too.

    It looks like this

    email 1 - Hello There email 2 - Re: Hello There

    Result Email 1 - Hello ThereSubject:RE Hello There Email 2 - Re: Hello There

    I looked a bit further now and it is definitely only with "conversations".

    Otherwise, everything is running very smoothly!

    Thanks!

  3. Janos SUTO repo owner

    Download the first email (with the longest subject), run pilertest against it, and verify that it concatenates with all previous subjects (in the eml file). Then download the master branch, and compile it, then run pilertest again, and check if it shows the proper subject line. Make sure to set the LD_LIBRARY_PATH to use the new version of the libpiler.so. If it's ok, then I suggest to upgrade, and it will fix the issue.

  4. Marnus van Wyk

    Thank you for the quick response

    I'll do a test setup of piler on another machine, here is the pilertest output from the one i posted previously just for completeness (1.1.1). Don't know "exactly" what to expect to see, it doesn't appear concatenated. It shows only one Subject line in * *'s. It looks ok!

    archiver_error3.png

    archiver_error4.png

    If you definitely believe master branch should sort it out, i'll absolutely give it a shot. Otherwise, conversations is not really that big a deal. Anyway to disable in config in the mean time?

  5. Marnus van Wyk

    I have a test environment setup now from the master branch. took a bit longer, but no biggies. It is run parallel as an additional journal rule so i can do like for like.

    The only difference is that the test piler instance is not running sso.

    piler -v marc01 - piler 1.1.1 build 904 marc02 - 1.2.0-master build 925

    The tweaks made since then is pretty good! Nice work!

    The subject issue is now better, but i don't know if it is exactly what it should be. Test Server 1.2.0 925 testserver1.PNG Live Server 1.1.1 904 liveserver1.png

    So all in all, the 925 build is significantly improved, it is not grouping on Thread-Index, or some other magic, but it looks miles better than the subject+subject+subject story.

    Going to run it another week, check that it is not falling over and then do an upgrade on production.

  6. Log in to comment