Anonymous avatar Anonymous committed 418b4b7

Remove duplicated shift statements and use named variable

Comments (0)

Files changed (1)

 # operation is currently done
 export PBCURRENTCOMMANDLINEOPERATION="$1"
 umask 0022
+shift
 
-case "$1" in
+case "${PBCURRENTCOMMANDLINEOPERATION}" in
     --create|create)
-	shift;
 	/usr/lib/pbuilder/pbuilder-createbuildenv "$@"
 	;;
     --update|update)
-	shift ;
 	/usr/lib/pbuilder/pbuilder-updatebuildenv "$@"
 	;;
     --build|build)
-	shift ;
 	/usr/lib/pbuilder/pbuilder-buildpackage "$@"
 	;;
     --clean|clean)
-	shift;
 	. /usr/lib/pbuilder/pbuilder-checkparams
 	if [ -n "$BASEBUILDPLACE" ]; then 
 	    log "I: Cleaning [$BASEBUILDPLACE]"
 	fi
 	;;
     --login|login)
-	shift 
 	. /usr/lib/pbuilder/pbuilder-checkparams
 	. /usr/lib/pbuilder/pbuilder-runhooks
 	extractbuildplace
 	;;
     --execute|execute)
 	# try to execute arbitrary program.
-	shift
 	. /usr/lib/pbuilder/pbuilder-checkparams
 	. /usr/lib/pbuilder/pbuilder-runhooks
 	EXECPROGRAM="$1"
 	exit $RET
 	;;
     --dumpconfig|dumpconfig)
-	shift
 	. /usr/lib/pbuilder/pbuilder-checkparams
 	. /usr/lib/pbuilder/pbuilder-runhooks
 	extractbuildplace
 	log "I: end dump config"
 	;;
     --debuild|debuild)
-	shift
 	"$0" execute "$@" /usr/lib/pbuilder/pdebuild-internal
 	;;
     *)
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.