Misspelling in required filename in submission instructions

[Rikard Nordgren]

A user at Uppsala tried to publish a model with accommodations thus adding the file Model_Accomodations.txt. Still the repository gave the error message: Model is not compliant with original publication. Please provide a Model_Accommodations.txt file.

[Mihai Glonț]

Is there a typo or is the file named 'Model_Accomodations.txt' instead of 'Model_Accommodations.txt'? We are looking for exact matches.

[Rikard Nordgren]

We made sure that there was no typo by copying the name from the tab with the submit guidelines.

[Mihai Glonț]

It's difficult to tell without looking at the model what the issue is. What is the model identifier?

[Rikard Nordgren]

Of course.

http://repository.ddmore.eu/model/DDMODEL00000224 It was now published without stating that it was modified.

Wait a second! It seems as if the spelling in the instructions are wrong. Must it be "Model_Accommodations.txt"? The instructions say "Model_Accomodations.txt". This might be it.

[Rikard Nordgren]

A related question: When searching the source code for this validation I can find the call to validModelAccomodation() but not the actual function. Where can I find it?

[Mihai Glonț]

The file name must be Model_Accommodations.txt (with double "m"). There is a typo in the submission guidelines!

[Mihai Glonț]

That's because we use a dedicated API for handling metadata validation. Please have a look at

https://github.com/pharmml/lib-metadata/blob/master/src/main/java/eu/ddmore/publish/service/PublishInfo.java#L83

[Rikard Nordgren]

Great! Thanks Mihai you have been very helpful. I suggest that this ticket is kept open until the typo has been corrected.

[Mihai Glonț]

okay, but if you don't mind, please update the title of the issue accordingly ;)

thanks for the feedback!

[Rikard Nordgren]

This has been resolved in the code and should be set as resolved. Upgrading the specific instance is of course unrelated. Sorry for asking you to keep this open.