in_array('update', $atts) returns TRUE even when 'update' is not in array

In gf_shortcode_atts() on line 123 I changed

elseif ( in_array('update', $atts) )

to

else if ( in_array('update', $atts, true) === true )

To fix this.

The error caused the form to get populated with the contents of the current page when the user was the author of the page (the admin in this case) even though the page was never created using the form and 'update' was NOT in the $atts array.

Settings the strict bool to TRUE as the third param in in_array makes it check for types as well, probably 'update' is also some kind of array property?

Comments (1)