Jakub Wilk avatar Jakub Wilk committed 1ec9734

event: be more strict when checking text.

Comments (0)

Files changed (1)

 import datetime
 import functools
 
+def _check_string(s):
+    if not isinstance(s, str):
+        raise TypeError
+    if not s:
+        raise ValueError('empty strings not allowed')
+    if s != s.strip():
+        raise ValueError('leading/trailing space not allowed')
+    if '\r' in s or '\n' in s:
+        raise ValueError('newlines not allowed')
+
 class Event(object):
 
     def __init__(self, date, text):
         if not isinstance(date, datetime.date):
             raise TypeError
-        if not isinstance(text, str):
-            raise TypeError
-        if text != text.strip():
-            raise ValueError('leading/trailing space not allowed')
+        _check_string(text)
         self.date = date
         self.text = text
 
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.