CryptedFileKeyring._unlock() does not return a value, forces _init_file()

Kyle Stark avatarKyle Stark created an issue

CryptedFileKeyring's keyring_key method includes the line

self._check_file() and self._unlock() or self._init_file()

However, self._unlock() does not return a value, causing self._init_file() to be called if the file exists and the correct password is entered. The fix would be to return a value from _unlock, or simply rewrite that line as

if self._check_file():
    self._unlock()
else:
    self._init_file()

Comments (3)

  1. Log in to comment
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.