Visual Studio 2019 implementation

[Jay M]

As the title suggests, would love this for VS 2019.

[Vik Donbother]

I just implemented support for VS2019. Please let me know of any problems.

[Jay M]

Hi Vik

When launching VS 2019 after installing, getting an error prompt. The following was logged to ActivityLog.xml:

‌

<entry><record>2080</record><time>2019/08/19 17:57:46.253</time><type>Information</type><source>VisualStudio</source><description>Begin package load [TFSCommentsPackage]</description><guid>{866AB2CC-6765-4E16-B8B7-1A8E9830E09D}</guid></entry><entry><record>2081</record><time>2019/08/19 17:57:46.441</time><type>Error</type><source>VisualStudio</source><description>SetSite failed for package [TFSCommentsPackage]Source: 'mscorlib' Description: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at System.Reflection.Assembly.GetTypes()
   at Karpach.Licensing.IntegrityManager.IntegrityCheck()
   at Karpach.TFSComments.TFSCommentsPackage.<InitializeAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Shell.AsyncPackage.<>c__DisplayClass19_0.<<Microsoft-VisualStudio-Shell-Interop-IAsyncLoadablePackageInitialize-Initialize>b__1>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.VisualStudio.Threading.JoinableTask.<JoinAsync>d__68.MoveNext()</description><guid>{866AB2CC-6765-4E16-B8B7-1A8E9830E09D}</guid><hr>80131602</hr><errorinfo></errorinfo></entry><entry><record>2082</record><time>2019/08/19 17:57:46.482</time><type>Error</type><source>VisualStudio</source><description>End package load [TFSCommentsPackage]</description><guid>{866AB2CC-6765-4E16-B8B7-1A8E9830E09D}</guid><hr>80131602</hr><errorinfo></errorinfo></entry>

‌

Have tried reinstalling but to no avail. Still seems to work in VS 2017.

Cheers

[Jay M]

Crashing on VS 2019

[Jay M]

[Vik Donbother]

Jay,

Microsoft changed Visual Studio 2019 internal structure in a way that it is not possible to write one extension that will work for both VS 2017 and 2019. I finally was able to adapt the extension to VS 2019. It is a separate extension TFS Comments 2019. The serial key should be the same.

[Jay M]

Fantastic thank you!