Daniel Greenfeld avatar Daniel Greenfeld committed 29dd08e

Remove deprecated method on the VisitorManager and the associated utils function

Comments (0)

Files changed (3)

visitor/managers.py

         try:
             return self.get(visitor_key=visitor_key)
         except self.model.DoesNotExist:
-            print("model doesn't exist")
-            return None
-            
-    def create_from_ip(self, ip):
-        from visitor.visitor_utils import create_uuid
-        return self.get_or_create(visitor_key=create_uuid(ip))[0]
+            return None

visitor/tests/test_models.py

 class BaseTestCase(TestCase):
         
     def tearDown(self):
+        super(BaseTestCase,self).setUp()        
         cache.clear()
 
 class VisitorModelTest(BaseTestCase):
         visitor.save()
         self.assertTrue(count < Visitor.objects.count())
 
+    """ test on possibly deprecated method
+    def test_manager_create_from_ip(self):
+        ip = '127.0.0.1'
+        visitor = Visitor.objects.create_from_ip(ip)
+        self.assertEquals(Visitor.objects.count(), 1)
+        
+        visitor = Visitor.objects.create_from_ip(ip)
+        self.assertEquals(Visitor.objects.count(), 1)        
+    """

visitor/visitor_utils.py

 
     return ip_address
 
-def get_visitor(visitor_key):
-    """ get the visitor using the visitor key """
-    return Visitor.objects.find_visitor(visitor_key)
-
 def create_visitor(ip_address,session_key):
     """ Create the visitor given an ip_address """
     visitor = Visitor()
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.