kenjis avatar kenjis committed 2cd11ad

fix form_prep() XSS bug

Comments (0)

Files changed (1)

system/helpers/form_helper.php

 		// @todo need to figure out a way to namespace this so
 		// that we know the *exact* field and not just one with
 		// the same name
-		if (isset($prepped_fields[$field_name]))
+		if (isset($prepped_fields[$field_name]) && $prepped_fields[$field_name] === $str)
 		{
 			return $str;
 		}
 
 		if ($field_name != '')
 		{
-			$prepped_fields[$field_name] = $field_name;
+			$prepped_fields[$field_name] = $str;
 		}
 
 		return $str;
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.