Set Expression dialog uses SAVE/CLOSE buttons, but seems more appropriate as OK/CANCEL

Create issue
Issue #75 resolved
Jeff Almasol created an issue
  1. open KBar Settings
  2. click Add Button > Set Expression, then give the expression a name and type the expression.
  3. click SAVE or click CLOSE.

--> unlike Scriptlets, there's no interactive (EXECUTE) mode, so what's the purpose of these names (e.g., SAVE not closing the dialog, CLOSE really cancelling changes)? am i missing some mode?

seems more consistent to have it as OK (and close immediately) and CANCEL, like most other dialogs for adding a button, at least the way expressions work right now.

Comments (4)

  1. Rafi Khan

    Made all the dialog modes consistent and renamed "EXECUTE" to "TEST" and also put it on the expression dialog.

  2. Log in to comment