Swapped source/destination IP/port in QOS Details for router -> WAN connections

[tievolu]

On the QOS “View Details” page, the table shows connections between the router and the WAN with source/destination IP addresses and ports incorrectly reversed.

The root cause is a piece of code which assumes that any IP address that isn’t in the main LAN VLAN must be a remote IP on the WAN. When the source IP is determined to be a remote IP, the code swaps the details round so that the source columns always describe the LAN side of the connection. This works fine unless the source is the router’s WAN IP, or a LAN IP that’s on a different VLAN to the main (default) LAN VLAN. In these cases the source IP is incorrectly identified as a remote IP, and the connection details are incorrectly reversed.

The problematic test needs to be improved so that it correctly identified remote IP addresses.

More details and discussion can be found here.