Remove NSE from gather call in combineIgphyml

Issue #74 resolved
Jason Vander Heiden created an issue

Check NOTE in `combineIgphyml`:

❯ checking R code for possible problems ... NOTE
  combineIgphyml: no visible binding for global variable ‘variable’
  combineIgphyml: no visible binding for global variable ‘value’
  combineIgphyml: no visible binding for global variable ‘ID’

See issue #73 for more details.

The following line needs to be converted to standard evaluation:

combined <- tidyr::gather(combined, variable, value, -ID)

Though, we might want to convert the output of readIghyml and combineIgphyml to an S4 class instead of a list. So I’d wait to fix this until deciding on that. (This doesn’t break anything, but a fix is needed for CRAN submission.)

Comments (6)

  1. Jason Vander Heiden reporter

    Okay. If you want a call over it, let me know. Object-oriented programming is kind of backwards in R. Classes “belong” to methods rather than methods belonging to classes. Sort of.

    The S4 object part itself is pretty straightforward though. It's the same thing as a list, but what you're allowed to put in the list is constrained (you give each item a name and a type). See the setClass calls in R/Classes.R for some examples.

  2. Kenneth Hoehn

    @Susanna Marquez did your last commit solve the dplyr issue for this? Was just getting to it.

  3. Log in to comment