1. Mikhail Korobov
  2. django-easy-maps
  3. Pull requests

Pull requests

#11 Merged
Repository
Deleted repository
Branch
default (f99493ea65a0)
Repository
django-easy-maps
Branch
default

Fix for 'ImportError: cannot import name GeocoderResultError'

Author
  1. Will Emmerson
Reviewers
Description

Made requested changes. Also got test project running with current version of Django (1.6)

Added python 3.3 and 1.6 as targets for tox.

Comments (4)

  1. Mikhail Korobov repo owner

    It seems that geopy.geocoders.base.GeocoderServiceError was added in geopy 0.96, and that exceptions were moved to geopy.exc module in 0.96. What about documenting that django-easy-maps requires geopy 0.96+ (and adding this info to setup.py), and using imports from geopy.exc? Alternatively, we can do a conditional import: if import from geopy.exc fails, try import exception from geopy.geocoders.base.

  2. Will Emmerson author

    Ah, I missed that, in fact I've never even heard of tox, but it sounds interesting. I probably should have done the testing changes in a seperate pull request. Do you think it's worth supporting django 1.3 and 1.4 with 1.7 about to be released? Is it worth trying to get it working for python3? (geopy and django 1.6 support it) Would it be easier to have tox call manage.py test rather than having multiple test runners?

  3. Mikhail Korobov repo owner

    I'm fine with dropping django 1.3 support because manage.py implementation changed in 1.4, and it becomes harder to support both 1.3 and modern django versions.

    If there is a compelling reason for dropping 1.4 support we may drop it as well, but is there such reason? It looks like django 1.4 support cost us nothing.

    It worths getting it work in python3 - tox is great for such efforts because it allows to check that you haven't broken 2.x support.

    As for runtests.py script, I'm fine with dropping it. What it is doing is calling manage.py test with proper arguments; this logic can be moved to tox.ini.