Issue #14 resolved

Support pip.conf uploading

Mikhail Korobov
repo owner created an issue

That's a good feature but I've temporary removed it from Vladimir's changes because

  • uploading to HOME dir doesn't seem clean: there can be several projects under 1 user account;
  • tests are failing

{{{

====================================================================== ERROR: test_deploy (fab_deploy_tests.tests.deploy.DeployTest)


Traceback (most recent call last): File "/Users/kmike/svn/django-fab-deploy/fab_deploy_tests/tests/deploy.py", line 96, in test_deploy fab(deploy_project) File "/Users/kmike/envs/planor/lib/python2.6/site-packages/fabtest/utils.py", line 21, in fab res = command(args, *kwargs) File "/Users/kmike/svn/django-fab-deploy/fab_deploy/deploy.py", line 34, in deploy_project virtualenv.pip_setup_conf() File "/Users/kmike/svn/django-fab-deploy/fab_deploy/virtualenv.py", line 34, in pip_setup_conf env.conf.HOME_DIR + '/.pip/pip.conf', check_existence=True) File "/Users/kmike/svn/django-fab-deploy/fab_deploy/utils.py", line 65, in upload_config_template if check_existence and not os.path.exists(config_template): File "/Users/kmike/envs/planor/bin/../lib/python2.6/genericpath.py", line 18, in exists st = os.stat(path) TypeError: coercing to Unicode: need string or buffer, NoneType found

}}}

Comments (7)

  1. Mikhail Korobov reporter

    Hi Vladimir,

    I've simplified patch a bit, added release notes and tests. The argument is renamed to 'skip_unexistent' for clarity. The HOME_DIR issue is resolved by calling 'pip_setup_conf' once per user inside 'create_linux_account'.

    Thanks for pushing this issue forward!

  2. Log in to comment