Issue #4 resolved
Carmen F. B. created an issue

Hi Evgeny! I've added Spanish language and 172x172 icon to your app, but I don't know how to do a pull request (sorry,I'm newbie in bitbucket).

My source is imported from yours and you can see here: https://bitbucket.org/carmenfdezb/deadbeef-silica/src/master/

Sorry for all the inconvenience and thanks for porting deadbeef!!

Comments (5)

  1. Evgeny Kravchenko repo owner

    Great! It's always a pleasure to see new contributions =)

    I checked commits in your fork and they look good. However, before they could be merged into the repo, some additional steps should be taken. Should I describe you what to do next to properly create Pull Request so we can thoroughly review your changes and commit them? The main advantage is that authorship of your changes will be properly preserved.

    Alternatively, I can handle everything by myself by moving your commits to the proper branch of the repo and fixing some minor things that should be fixed according to my opinion. The downside of this is that authorship of your commits probably will not be preserved

    How do we proceed?

  2. Evgeny Kravchenko repo owner

    I made some research and it turns out that the authorship of your changes will be properly preserved even if I'll move your changes to the repo by myself. So if you don't want to poke around with git and prefer me to handle the rest, this is also a feasible option. What do you think on this?

  3. Carmen F. B. reporter

    I agree with you, and I think it's the best way:) Thanks for everything, I hope this isn't an inconvenience for you.

  4. Evgeny Kravchenko repo owner

    Okay. I've already merged change with an icon to the develop branch and a change with the new translation to the dedicated branch along with some required changes. I'll review it and once it's finished, I'll also merge it to the develop branch.

    There are also some things related to translation that I'd want to discuss. Could you please write me to cravchik[at]yandex.ru so we can continue our conversation?

  5. Log in to comment