Quest Olympiad Starter

[Sahar Atias]

Sometimes you get more quest items and then the quest cannot be finished, dunno why but a simple solution can probably be. Note this isn't the best solution because it checks count, since you need 1 of every certificate. Doing such checks means if you got 2 certs 3 for example and 1 more cert 5 then the quest will be completed, while it shouldn't. So you should come up with your own more proper fix.

diff --git a/dist/game/data/scripts/quests/Q00551_OlympiadStarter/Q00551_OlympiadStarter.java b/dist/game/data/scripts/quests/Q00551_OlympiadStarter/Q00551_OlympiadStarter.java
index 2b2921a..6048771 100644
--- a/dist/game/data/scripts/quests/Q00551_OlympiadStarter/Q00551_OlympiadStarter.java
+++ b/dist/game/data/scripts/quests/Q00551_OlympiadStarter/Q00551_OlympiadStarter.java
@@ -67,7 +67,7 @@
       }
       else if (event.equalsIgnoreCase("31688-04.html"))
       {
-         final long count = st.getQuestItemsCount(CERT_3) + st.getQuestItemsCount(CERT_5);
+         final long count = Math.min(st.getQuestItemsCount(CERT_3) + st.getQuestItemsCount(CERT_5), 2);
          if (count > 0)
          {
             st.giveItems(OLY_CHEST, count); // max 2
@@ -228,7 +228,7 @@
       }
       else if (st.isStarted())
       {
-         final long count = st.getQuestItemsCount(CERT_3) + st.getQuestItemsCount(CERT_5) + st.getQuestItemsCount(CERT_10);
+         final long count = Math.min(st.getQuestItemsCount(CERT_3) + st.getQuestItemsCount(CERT_5) + st.getQuestItemsCount(CERT_10), 3);
          if (count == 3)
          {
             htmltext = "31688-04.html";

[AstroGG]

I think this should be posted in L2J_Datapack repository because its part of game/data/scripts

[TheArtOfCleanCode]

Htmls 31688-s1.html 31688-s2.html are the same. Datapack commit that fix this issue 86c5398.

[Adry_85]

Fixed in https://bitbucket.org/l2jserver/l2j_datapack/commits/3dc5ac3fbb9a7803cee587da39121399e26db14b

Thanks