Serious debuff issue.

[Sahar Atias]

There's a bug atm on l2jserver that if a player debuffs target multiple times that has traits (for example - tribunal) at some point onExit() would be called more than once, this results in traits becoming stronger and stronger the more it happens until the player actually becomes immune

I applied this temp fix which worked so far, but you should seriously consider reworking that crap, it can easly be tested logging traitsCount and traits values.

diff --git a/dist/game/data/scripts/handlers/effecthandlers/AttackTrait.java b/dist/game/data/scripts/handlers/effecthandlers/AttackTrait.java
index 9b11e47..e7c05ca 100644
--- a/dist/game/data/scripts/handlers/effecthandlers/AttackTrait.java
+++ b/dist/game/data/scripts/handlers/effecthandlers/AttackTrait.java
@@ -61,6 +61,11 @@
        {
            for (Entry<TraitType, Float> trait : _attackTraits.entrySet())
            {
+               if (charStat.getAttackTraitsCount()[trait.getKey().getId()] == 0)
+               {
+                   return;
+               }
+               
                charStat.getAttackTraits()[trait.getKey().getId()] /= trait.getValue();
                charStat.getAttackTraitsCount()[trait.getKey().getId()]--;
            }

diff --git a/dist/game/data/scripts/handlers/effecthandlers/DefenceTrait.java b/dist/game/data/scripts/handlers/effecthandlers/DefenceTrait.java
index 1ecf197..5b5443b 100644
--- a/dist/game/data/scripts/handlers/effecthandlers/DefenceTrait.java
+++ b/dist/game/data/scripts/handlers/effecthandlers/DefenceTrait.java
@@ -80,11 +80,21 @@
            {
                if (trait.getValue() < 2.0f)
                {
+                   if (charStat.getDefenceTraitsCount()[trait.getKey().getId()] == 0)
+                   {
+                       return;
+                   }
+                   
                    charStat.getDefenceTraits()[trait.getKey().getId()] /= trait.getValue();
                    charStat.getDefenceTraitsCount()[trait.getKey().getId()]--;
                }
                else
                {
+                   if (charStat.getTraitsInvul()[trait.getKey().getId()] == 0)
+                   {
+                       return;
+                   }
+                   
                    charStat.getTraitsInvul()[trait.getKey().getId()]--;
                }
            }

[FinalDestination]

patch fix:

@@ -1430,7 +1430,7 @@ public void add(BuffInfo info)
        // Where new buff should be placed
        if (skill.getAbnormalType().isNone())
        {
-           stopSkillEffects(false, skill);
+           stopSkillEffects(true, skill);
        }
        // Verify stacked skills.
        else
 @@ -1460,7 +1460,7 @@ public void add(BuffInfo info)
                    {
                        if (stackedInfo.getSkill().isAbnormalInstant())
                        {
-                           stopSkillEffects(false, skill.getAbnormalType());
+                           stopSkillEffects(true, skill.getAbnormalType());
                            stackedInfo = _stackedEffects.get(skill.getAbnormalType());
                        }

 @@ -1477,9 +1477,9 @@ public void add(BuffInfo info)
                    {
                        if (stackedInfo.getSkill().isAbnormalInstant())
                        {
-                           stopSkillEffects(false, skill.getAbnormalType());
+                           stopSkillEffects(true, skill.getAbnormalType());
                        }
-                       stopSkillEffects(false, skill.getAbnormalType());
+                       stopSkillEffects(true, skill.getAbnormalType());
                    }
                }

[ShinichiYao]

This seems cause triggered skills issue.

[FinalDestination]

what u mean exactly ?

[ShinichiYao]

Trigger skills triggered and disappear if you have lot of trigger skill triggered at same time especially using pole hitting mobs.

[Adry_85]

Issue #227 was marked as a duplicate of this issue.

[FinalDestination]

andry please check this out is serious

[Adry_85]

I'm checking on it

[Adry_85]

Can you please add this line on L2Character addSkill and check if is ok?

https://pastebin.com/9Gq47cJB

Thanks

[FinalDestination]

fixed you are the best

[Adry_85]

Fixed in https://bitbucket.org/l2jserver/l2j_server/commits/5bc7189918f29242a96fc762f04f4d800dbb1087.

Thanks

[ShinichiYao]

Only fixed passive skills? What about Tribunal(id:400) for example?

[Sahar Atias]

Yup, you gave @FinalDestination to test one thing and then you commit a different thing. Tribunal isn't a passive skill and therefore i'm pretty sure this issue still exists.

[Adry_85]

reopened

[FinalDestination]

this is for triggers buffs etc or only debuffs? because triggers buffs goes double too

[Maneco2]

Look this debuff poison in dragon valley center, more doubles and client crashes is not remove debuff fast...

[CostyKiller]

Any fix for this problem? This is still active on last revision.

[Maneco2]

Issue #326 was marked as a duplicate of this issue.

[Maneco2]

Issue #299 was marked as a duplicate of this issue.

[Maneco2]

Issue #260 was marked as a duplicate of this issue.

[MaGa]

This don’t fix this big bug on pailaka when u using the pole.

‌

[proGenitor]

Holy shit!

[Antonio Martínez]

Any other can reproduce it?

[Zoey76]

@Maneco2 if this didn’t fix the issue with Pailaka buff, what did it fix?

[Maneco2]

@Zoey76 the issue #299

[proGenitor]

Maybe it will fix that shit.. https://bitbucket.org/MobiusDev/l2j_mobius/commits/9bde8c60ecc772e450b63207f1e7aeae6c6e90c3

[Maneco2]

Reproduced easy: https://www.youtube.com/watch?v=23sKqNEcx04

[[e-mail]]

@Sahar Atias The reason has been found: issue #331

#24 and #331 Is the same problem.

#260 and #227 and #299 Is another problem