spamming NPE after last commits

[Former user]

and when using the skill (for example, 1332) nothing happens

callSkill() failed. {} java.lang.NullPointerException
        at com.l2jserver.gameserver.model.actor.instance.L2ServitorInstance.getMaxHp(L2ServitorInstance.java:377)
        at handlers.effecthandlers.pump.MaxHp.onStart(MaxHp.java:92)
        at com.l2jserver.gameserver.model.skills.BuffInfo.initializeEffects(BuffInfo.java:276)
        at com.l2jserver.gameserver.model.CharEffectList.add(CharEffectList.java:1245)
        at com.l2jserver.gameserver.model.skills.Skill.applyEffects(Skill.java:1381)
        at com.l2jserver.gameserver.model.actor.L2Character.addSkill(L2Character.java:5250)
        at com.l2jserver.gameserver.model.actor.L2Character.<init>(L2Character.java:350)
        at com.l2jserver.gameserver.model.actor.L2Character.<init>(L2Character.java:285)
        at com.l2jserver.gameserver.model.actor.L2Playable.<init>(L2Playable.java:67)
        at com.l2jserver.gameserver.model.actor.L2Summon.<init>(L2Summon.java:100)
        at com.l2jserver.gameserver.model.actor.instance.L2ServitorInstance.<init>(L2ServitorInstance.java:57)
        at handlers.effecthandlers.instant.Summon.onStart(Summon.java:78)
        at com.l2jserver.gameserver.model.skills.Skill.applyEffectScope(Skill.java:1232)
        at com.l2jserver.gameserver.model.skills.Skill.applyEffects(Skill.java:1329)
        at com.l2jserver.gameserver.model.skills.Skill.applyEffects(Skill.java:1255)
        at com.l2jserver.gameserver.model.skills.Skill.activateSkill(Skill.java:1469)
        at com.l2jserver.gameserver.model.skills.Skill.activateSkill(Skill.java:1392)
        at com.l2jserver.gameserver.model.actor.L2Character.callSkill(L2Character.java:5796)
        at com.l2jserver.gameserver.model.actor.L2Character.onMagicHitTimer(L2Character.java:5598)
        at com.l2jserver.gameserver.model.actor.tasks.character.MagicUseTask.run(MagicUseTask.java:66)
        at com.l2jserver.gameserver.ThreadPoolManager$RunnableWrapper.run(ThreadPoolManager.java:89)
        at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
        at java.util.concurrent.FutureTask.run(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
        at java.lang.Thread.run(Unknown Source)

[CostyKiller]

same here, this happens when i try to summon imperial phoenix, unicorns, mechanical golem etc.

[rbrtflr]

Same here, It happens with any servitor I try to summon of any class I tested so far.

[Mertan Ahmed]

this is caused because maxHP was reworked as a skill and many skills are added before we set the owner of the pet/servitor

[CostyKiller]

and how can we fix that?

[Mertan Ahmed]

i cant give u proper patch if you know some basics u can do it manually, you just have to move 2 codes thats all, it worked fine for me i dont know about side effects

https://justpaste.it/5eoct

[CostyKiller]

Seems ok, I will add it to live server see if anything appears. thx for it.

[Mertan Ahmed]

report anything unusual, ill fix it immediatelly.

[rbrtflr]

@BruSsa88 I edited that lines and recompiled the server and now everything seems to work just fine. I think I found something strange, but I wonder if it's just the normal behaviour (so long I don't play L2); if I summon something and then I disconnect, when I reconnect again the servitor appears too, without summoning him.

[CostyKiller]

Hi! You can disable that in Character.properties

# Servitor summons on login if player had it summoned before logout
# Default: True
RestoreServitorOnReconnect = True

[Zoey76]

Fixed in https://bitbucket.org/l2jserver/l2j_server/commits/28d23828767c, thanks all