Critical Instance BUGs (Zaken Frintezza Freya Tiat...)

[ShinichiYao]

Player can enter Instance with no reenter time limit

For example: 9 characters enter the instance and killed the Boss, before the instance end they just need kick one member out the party and leave him in the instance, others go out the instance and add one new member to the party then give the the party leader to him, let the new member enter the instance again, the instance will be regenerate with no reenter time limit.

Because AbstractInstance.java missing check if Party or CommandChannel members already enter the instance with same id when firstEntrance is true.

[Maneco2]

This is an missing check only

if (checkConditions(player))

[ShinichiYao]

On first enter each member should be checked if they already enter the instance.

    @Override
    protected boolean checkConditions(L2PcInstance player)
    {
        ...
        for (L2PcInstance channelMember : channel.getMembers())
        {
            ...
+           final InstanceWorld worldTest = InstanceManager.getInstance().getPlayerWorld(channelMember);
+           if (worldTest != null)
+           {
+               SystemMessage sm = SystemMessage.getSystemMessage(SystemMessageId.C1_MAY_NOT_RE_ENTER_YET);
+               sm.addPcName(channelMember);
+               party.broadcastPacket(sm);
+               return false;
+           }
        }
        return true;
    }

‌