Major Issue for Rates above x1 PreciseDropCalculation Reqire Rework

[Nikolay Petrov]

Developer Source Latest

‌

PreciseDropCalculation = true

DeathDropAmountMultiplier = 1

CorpseDropAmountMultiplier = 1

DeathDropChanceMultiplier = 15

DropAmountMultiplierByItemId = 57,15
DropChanceMultiplierByItemId = 57,1

‌

Drop precision ignores item chances when it comes to apply amountMultiply.

Bug is persistent on any group that has chances,

exceeding 100% due to DeathDropChanceMultiplier and is Precise Calculated.

‌

Here is example on groups with 500+ chance

and clearly item drop chance is not taken in consideration.

‌

Here is video with example of this bug.

https://www.youtube.com/watch?v=HazKN7KhKvs

This is very rough calculation.

I find drop calculation nowhere precise.

‌

I have already provided solution for Core files as well for NpcViewMod feature.

Until branch is updated links will be provided here.

https://bitbucket.org/l2jserver/l2j-server-game/pull-requests/35

[Nikolay Petrov]

Here is some additional content.

‌

‌

1728 Metallic fiber at 8.6571% chance

‌

‌

<npc id="22753" level="85" type="L2Monster" name="Elite Treykan" title="Bistakon">

        <death>
            <group chance="70">
                <item id="57" min="82667" max="170383" chance="100" /> <!-- Adena -->
            </group>
            <group chance="5.046299934387207">
                <item id="13467" min="1" max="1" chance="0.2333" /> <!-- Vesper Thrower -->
                <item id="15644" min="1" max="1" chance="99.7667" /> <!-- Vesper Thrower Piece -->
            </group>
            <group chance="48.35210037231445">
                <item id="1895" min="72" max="216" chance="8.6571" /> <!-- Metallic Fiber -->
                <item id="4040" min="2" max="6" chance="17.4527" /> <!-- Mold Lubricant -->
                <item id="9628" min="3" max="9" chance="4.8887" /> <!-- Leonard -->
                <item id="9630" min="1" max="1" chance="22.964" /> <!-- Orichalcum -->
                <item id="16160" min="1" max="1" chance="21.0781" /> <!-- Life Stone - Level 85 -->
                <item id="16161" min="1" max="1" chance="5.2632" /> <!-- Mid-Grade Life Stone - Level 85 -->
                <item id="15825" min="1" max="1" chance="0.3044" /> <!-- Recipe - Vesper Thrower (60%) -->
                <item id="15486" min="1" max="1" chance="19.3918" /> <!-- Spirit Stone Fragment -->
            </group>
        </death>

‌

[Nikolay Petrov]

https://bitbucket.org/l2jserver/l2j-server-game/pull-requests/35/l2jserver-most-precise-drop-strategy