Anonymous committed 8f5b8af

Flip the activation URLConf back to match on \w+ and add a comment explaining why.

Comments (0)

Files changed (1)

 from views import activate, register
 urlpatterns = patterns('',
-                       (r'^activate/(?P<activation_key>[a-fA-F0-9]+)/$', activate),
+                       # Activation keys get matched by \w+ instead of the more specific
+                       # [a-fA-F0-9]+ because a bad activation key should still get to the view;
+                       # that way it can return a sensible "invalid key" message instead of a
+                       # confusing 404.
+                       (r'^activate/(?P<activation_key>\w+)/$', activate),
                        (r'^login/$', login, {'template_name': 'registration/login.html'}),
                        (r'^logout/$', logout, {'template_name': 'registration/logout.html'}),
                        (r'^register/$', register),
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.