Author Commit Message Labels Comments Date
Default avatar boredzo
Added debug messages to help me figure out why GrowlMail was posting notifications for message moves and copies.
Branches
default
Default avatar boredzo
Added suicide-pill guards for cases where the messageCopies variable underflows or overflows.
Branches
default
Default avatar boredzo
Xcode 2.5 helpfully corrected the UTIs of a few strings files for me.
Branches
default
Default avatar evands
revert part of [2716] which made webkit override shouldDelayWindowOrderingForEvent 'so that the notifications are not ordered front when clicked.' without overriding this, we still don't switch the active application, and its overriding breaks any change in window focus or application activity which happens within the event's invocation's run loop -- which includes an application switching to be active in response to a click. Fixes Adium Trac ticket 9494
Branches
default
Default avatar boredzo
Changed GrowlApplicationController to use the SystemSound API to play sounds.
Branches
default
Default avatar boredzo
Fixed the warning on launch about the the Growl UDP pathway being unable to bind the socket. This happened since [4803] when Growl was set to listen for forwarded notifications. It didn't happen before that revision because we terminated before the pathways were instantiated (also before any documents were opened, which was the problem it fixed).
Branches
default
Default avatar boredzo
Changed -runningHelperAppBundle to not call bundleWithIdentifier:, so that it isn't dependent on whether a bundle with that identifier was ever previously instantiated from another method.
Branches
default
Default avatar evands
Find the largest rep when looking for a bitmap image rep
Branches
default
Default avatar boredzo
The fix in [4803] doesn't really register apps still using the old GAB; it will save a ticket for them, but the running GHA won't know about the ticket until it next relaunches. The correct behavior in that case is to reopen the .growlRegDict file with the running GHA, so that the application really does get registered with it immediately.
Branches
default
Default avatar boredzo
Made +runningHelperAppBundle public, and documented it, and updated the documentation of +helperAppBundle and +growlPrefPaneBundle to note that they use it.
Branches
default
Default avatar boredzo
Delegate the opening of .growlRegDict files to a new GrowlPropertyListFilePathway, and only terminate the app one second after the last file is processed.
Branches
default
Default avatar boredzo
Removed a Copy Files phase from the prefpane target, because I don't think we need to put headers into the Resources folder of the prefpane.
Branches
default
Default avatar boredzo
GrowlPathUtilities' search for the GrowlHelperApp bundle now looks for a running GHA process first. If found, it returns the bundle for that process.
Branches
default
Default avatar boredzo
Corrected definition of GROWL_HELPERAPP_BUNDLE_IDENTIFIER to actually use the correct name.
Branches
default
Default avatar boredzo
Renamed HelperAppBundleIdentifier to GROWL_HELPERAPP_BUNDLE_IDENTIFIER, and moved it to GrowlDefinesInternal.h (just below GROWL_PREFPANE_BUNDLE_IDENTIFIER).
Branches
default
Default avatar boredzo
Include the PID in the registration-dictionary filename, to aid testing.
Branches
default
Default avatar evands
Fix naming conflict on 10.5+; bitmapImageRep is used, and we want our own implementation.
Branches
default
Default avatar evands
Removed deleted header reference
Branches
default
Default avatar boredzo
-[NSImage TIFFRepresentation] is expensive. *Very* expensive (90% of the CPU time in last night's Shark run on GrowlTunes - in fact, TIFFRepresentation was the reason why invoking registrationDictionaryForGrowl needlessly was so expensive). Let's not call it unless we need to.
Branches
default
Default avatar boredzo
Fixed the build: Evan deleted GrowlWebKitImageURLProtocol in [4793], so we must also not import it.
Branches
default
Default avatar evands
Remove GrowlImageURLProtocol, which revealed a major leak bug somewhere deeper in the system and led us to leak every image we displayed in WebKit. Replace it with use of the data: schema for images, embedding a base64 encoded version of the PNG data for the image directly in the HTML we give to WebKit. Not only does this finish up fixing the leaks in WebKit displays, it makes our transient memory usage a double handful of kilobytes per notification on-screen rather than about 200 kb.
Branches
default
Default avatar evands
Don't retain every image we're passed forever by setting a name for it and then not unsetting it. This, too, doesn't appear to fix all the leaks, but it's a step in the right direction. (WebKit displays only)
Branches
default
Default avatar evands
Don't register GrowlImageURLProtocol multiple times, and don't call super's version of initialize
Branches
default
Default avatar evands
Let's not leak every GrowlWebKitWindowView and all of its heirarchy with every notification of a webkit-based display. This doesn't fix all the memory leaks, but it fixes a big one.
Branches
default
Default avatar boredzo
Carbon version of [4788] (caching the registration dictionary).
Branches
default
Default avatar boredzo
We now keep the registration dictionary around, unless somebody calls registerWithDictionary: or setGrowlDelegate:. Previously, we re-retrieved and re-built the reg dict on *every* notification.
Branches
default
Default avatar evands
If the rating is 0, just don't show the rating information at all. I use ratings on some songs, so want to see it when it's there, but don't want to see 5 hyphens on all the other songs
Branches
default
Default avatar boredzo
Fixed bug where not having Growl installed gets you *both* error messages. We now only show the reg-failed error message if Growl is installed and it fails anyway.
Branches
default
Default avatar boredzo
Fixed grammar of GrowlTunes error messages (especially the two comma splices).
Branches
default
Default avatar boredzo
Fixed crash on launch in GrowlTunesPlugin when Growl isn't installed, by correcting the length of the array if our attempt to retrieve the Growl icon returns NULL.
Branches
default
  1. Prev
  2. Next
Help
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.