Proposing major changes
Issue #1
resolved
Thank you for your module. It seems like the best one around so far that I've found, however as you know it doesn't have rhel support. I've forked your repo and am working on a lot of changes and was curious on what your policy is for reviewing and merging PR's. I still have a good bit more work to do, but below are some of the changes I am implementing:
- add rhel support
- add a params class that handles differences in OS
- change parameters to have their defaults and be able to be overridden in a single hieradata hash
- breaking out the auth_list and databases variables to be their own classes with create_resources (allowing a lot of cool things to be done with hieradata and wrapper functions)
I'm still working on the last bullet point and have not updated or added any tests yet, but wanted to see if you would be open to merging this drastic of a PR when the time comes. As far as I can tell without explicit testing, I haven't changed anything that would break it for Ubuntu/Debian based systems.
You can view the branch in progress on my fork at https://bitbucket.org/covermymeds/puppet-pgbouncer/branch/add-other-os-support
Best Regards, CJ Estel CoverMyMeds
Comments (6)
-
reporter
-
@cjestel Thank you for this. I didn't have notifications setup on my repos so I apologize for not getting to this sooner! Yes, we are open to community contributions. I will look into the merge request and get back to you.
-
@cjestel I have rejected the changes due to the pull request containing a licence change from GPLv3 to MIT. Why did you attempt to change the license?
-
reporter
Sorry about that, after not seeing any response to the initial question for a couple of weeks I talked it over with my team and they suggested since we do all of our open source work in github that I structure it as a new module released through our company. I moved forward with that approach and when I got to my initial working copy figured I'd at least attempt to push it your direction. Our company uses the MIT license and it was an oversight when I pushed it your way that I did not revert it back.
I've got a handful of changes past what I had pushed up here in bitbucket that are available in our company's github page at www.github.com/covermymeds/puppet-pgbouncer
If you'd like, take a look at what I've got up there, and maybe we can work together to either combine things or make sure that we can properly support as many OS's as possible. My module has been tested on RHEL 6 and 7 with pgbouncer versions 1.5, 1.6, and the master branch available from the pgbouncer site. I'm really excited for the next major release as I've tested and gotten working the SSL/TLS stuff through the updated module.
-
@cjestel Thank you for your response. I have created an issue in your github repo requesting that you change the license back to the GPLv3.
I am willing to work with you to add in the additional changes but we must continue to be compliant with the GPLv3 license.
Thank you
-
- changed status to resolved
License issue resolved. Can look at changes for merge.
- Log in to comment
It looks like I might end up having a dependency on the concat module as well. I also added a dependency on the puppetlabs-postgresql module to achieve the ability to get the appropriate repo's in place for downloading the package.