1. leapfrogdevelopment
  2. PunkyBrowster
  3. Pull requests

Pull requests

#1 Merged
Repository
punkybrowster.work
Branch
default
Repository
PunkyBrowster
Branch
default

Thoughts on this?

Author
  1. Brendan McCollam
Reviewers
Description

I think it would be nice to allow the Punky form methods to operate directly on QWebElements passed in as an argument. This is especially useful in situations where an element doesn't a have an ID or another easy way to uniquely identify it with CSS selectors. It's also convenient in situations where you've got the QWebElement at hand, and it would be more trouble to craft an appropriate CSS selector.

Any objections?

Comments (2)

  1. Jesse London

    I'm not against the change, but I'm curious — if the element is so difficult to select via CSS, how are you getting it in the first place? In your tests you select the element by CSS first.

    Also, what's with the default timeout changes?

  2. Feihong Hsu

    I'm OK with the change. Although I feel it dances around the issue of having a wrapper object for QWebElement that contains all the convenience methods on it. But that default timeout seems way too small.