1. Lorenzo Gil
  2. djangosaml2
  3. Issues
Issue #10 new

Documentation misleading: SAML_CONFIG['valid_for'] is ignored

Anonymous created an issue

The example SAML_CONFIG in the documentation contains a valid_for parameter, but looking the code in djangosaml2.views.metadata this parameter is ignored and the value of SAML_VALID_FOR is used instead.

It might be good to remove this from the default config in case it confuses anyone else.

Comments (2)

  1. Lorenzo Gil repo owner

    Thanks for noticing this and sorry about the confussion.

    Before fixing this in djangosaml2, I've created an issue in pysaml2 since that's the source of confusion here:

    https://github.com/rohe/pysaml2/issues/9

    Depending on the resolution of the pysaml2 bug I'll remove the 'valid_for' parameter from the SAML_CONFIG option or remove the SAML_VALID_FOR option.

  2. Log in to comment