Commits

Anonymous committed cfee163

- #18, Removed invalid gdFree call when overflow2 fails
- #17, Free im->pixels as well on error

Comments (0)

Files changed (2)

      (John Ellson/Graphviz)
 #17, Added "static" to entities_s struct declaration to avoid obscure 
      compiler problem on Suns (John Ellson/Graphviz)
+#18, Removed invalid gdFree call when overflow2 fails
   gdImagePtr im;
 
   if (overflow2(sizeof (unsigned char *), sy)) {
-	gdFree(im);
-	return NULL;
+		return NULL;
+  }
+  if (overflow2(sizeof (unsigned char *), sx)) {
+		return NULL;
   }
 
   im = (gdImage *) gdMalloc (sizeof (gdImage));
 				{
 					gdFree(im->pixels[i]);
 				}
+				gdFree(im->pixels);
 				gdFree(im);
 				return NULL;
 			}
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.