Commits

Anonymous committed cfee163

- #18, Removed invalid gdFree call when overflow2 fails
- #17, Free im->pixels as well on error

Comments (0)

Files changed (2)

      (John Ellson/Graphviz)
 #17, Added "static" to entities_s struct declaration to avoid obscure 
      compiler problem on Suns (John Ellson/Graphviz)
+#18, Removed invalid gdFree call when overflow2 fails
   gdImagePtr im;
 
   if (overflow2(sizeof (unsigned char *), sy)) {
-	gdFree(im);
-	return NULL;
+		return NULL;
+  }
+  if (overflow2(sizeof (unsigned char *), sx)) {
+		return NULL;
   }
 
   im = (gdImage *) gdMalloc (sizeof (gdImage));
 				{
 					gdFree(im->pixels[i]);
 				}
+				gdFree(im->pixels);
 				gdFree(im);
 				return NULL;
 			}