2.1.0 final reports as 2.1.0-alpha
This is just a reminder
$ grep VERSION src/gd.h
#define GD_MAJOR_VERSION 2
#define GD_MINOR_VERSION 1
#define GD_RELEASE_VERSION 0
#define GD_EXTRA_VERSION "alpha"
#define GD_VERSION_STRING "2.1.0-alpha"
Need to find a better way to handle this (from configure macro ?)
Also need to check CMakefile.txt
Comments (13)
-
Account Deleted -
Or use the defines? Avoiding generation would be nicer
-
Account Deleted Why avoid the generation? Changing the same number at two places will always fail.
-
Thoughts about using /D, not sure it is possible with gcc
-
Account Deleted No exactly sure what you mean, I use Windows only as firmware for booting SWTOR :)
-
/D is the same as #define
-
Account Deleted The other option would be to (re)generate the file when making "make dist", but I am not sure if it's worth the trouble.
-
Not worth, I will port the fix to nmake and cmake . Thanks!
-
Account Deleted I still don't understand how would you avoid changing the installed gd.h – those #defines are public and I am pretty sure that people are checking them after including gd.h, e.g. dropping the #defines from gd.h would change API and we want to avoid that as much as possible.
-
Him.. Right :)
-
Account Deleted - changed status to resolved
Resolved in 5b917b4
-
Account Deleted Well, only the autotools parts, @pierrejoye could you pull the fix into CMake, please?
-
I downloaded and installed 2.1.0 by following the links on the homepage - it lead me to:
https://bitbucket.org/libgd/gd-libgd/downloads/libgd-2.1.0.tar.bz2
This file still reports as '2.1.0-alpha'. Could someone please update these files?
- Log in to comment
@pierrejoye Could we generate gd.h from gd.hin? This seems to be a very simple to implement.