Pull requests

#3 Merged
Repository
Branch
php-libgd
Repository
Branch
master

Merge missing functions to compile PHP GD library

Author
  1. Ondřej Surý avatarOndřej Surý
Reviewers
Description

Hi,

this will need careful review and there are still some changes in the GD library functionality not merged from PHP to GD version (number of tests are still failing due different output of some functions).

But this at least makes the API complete PHP GD extension wise.

Comments (13)

  1. Pierre Joye

    Not sure we need the AA for PHP. Actually PHP never exposed nor used these functions but the other AA functions for line and co.

    I would rather not provide the overlay methods as well, they are really not complete and I would hate to have to maintain them forever. GD 2.2 will have a blending API which can be used for the same purposes and will also provide what these functions try to provide. Also if really desired we can add the overlay functions to gd PHP's code.

    Thoughts?

  2. Ondřej Surý author

    Whatever suits you, but you will have to modify PHP GD ext yourself then :).

    I have an already working (it compiles, runs and don't segfault) matching patch for PHP 5.5.0-alpha3 and I have tried to limit the exposing of the gd-libgd functions to minimum.

  3. Pierre Joye

    Not sure my other comment made it here :)

    Do you have a php's git account? You should have one and I can give you access to php-src, or ext/gd :)

  4. Ondřej Surý author

    Should I split this pull request into individual parts? We will need to merged the jpeg Ex functions and some other parts anyway. So I'll just drop the AA from this pull request. Would that be ok?

  5. Ondřej Surý author

    Pierre, could you check it now? This pull request adds jpeg*Ex functions, the gdImageXbmCtx from PHP (we need to solve the licensing issue though) and gdImageColorMatch (also from PHP).

  6. Pierre Joye

    Go ahead with the license, it is clearly a port/copy-paste from gd. No issue here and I know Marcus very well, he won't have any opposition :)

Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.