Pull requests

#4 Declined
Repository
Deleted repository
Branch
issue-build (bf556c30dfe8)
Repository
libgd libgd
Branch
master

export gdCalloc

Author
  1. Remi Collet
Reviewers
Description

gdCalloc is used in lot of tests, so need to be exported to allow the build of this test units using the just build shared library.

Note : alternative is to not use gdCalloc / gdFree in unit test, but calloc / free instead

Tests concerned:

tests/gdimageopenpolygon/gdimageopenpolygon1.c
tests/gdimageopenpolygon/gdimageopenpolygon3.c
tests/gdimageopenpolygon/gdimageopenpolygon2.c
tests/gdimagefilledpolygon/gdimagefilledpolygon1.c
tests/gdimagefilledpolygon/gdimagefilledpolygon3.c
tests/gdimagefilledpolygon/gdimagefilledpolygon2.c
tests/gdimagepolygon/gdimagepolygon3.c
tests/gdimagepolygon/gdimagepolygon1.c
tests/gdimagepolygon/gdimagepolygon2.c

Comments (3)

  1. Ondřej Surý

    I don't think this is a good idea, because this symbol might be in turn used not only in tests, but also in all other users of the shared library, and I am not sure we want that. This might be fixed by linking test with static library instead.

  2. Remi Collet author

    But I don't want to build the static library. And I'd like the test to test the just built library which will be packaged, not something else.

    So ? switching to calloc / free in those tests ?