Command arg to var proposal

Issue #12 resolved
Aaron Bartell created an issue

I was furthering my use of chroot_minimal.lst and realized only the :system portion had variable substitution (i.e. $myuser). I'd like to propose we introduce that into other areas also.

I've created a snippet with a git diff of my proposed changes.

Thoughts?

Comments (6)

  1. Aaron Bartell reporter

    @rangercairns What are your thoughts on this? Note it slows everything down because each line is separately processed. Might be better to do a single complex sed.

  2. Former user Account Deleted

    I have no idea what you are doing here ... snippet looks the same as original code ...

  3. Aaron Bartell reporter

    I neglected to give a bigger picture. My proposal removes the arg replacement from function chroot_system and instead puts it in function chroot_setup.

    Essentially it makes arg replacement work for all sections (i.e. :system, :cp, :chmod, etc)

  4. Former user Account Deleted

    Oh moved to script "main" (and store global var), wherein, any function could use parsed replacements. Seems reasonable to me.

  5. Log in to comment