Lenard Lindstrom avatar Lenard Lindstrom committed 3705fa5

Fix Surface instance reference count bug when a Surface.get_view() is garbage collected.

Add an extra surface Py_DECREF to remove the new reference returned by PgView_GetParent().

Comments (0)

Files changed (1)

 static void
 surf_view_destr(PyObject *view)
 {
-    PySurface_UnlockBy(PgView_GetParent(view), view);
+    PyObject *surf = PgView_GetParent(view);
+
+    PySurface_UnlockBy(surf, view);
+    Py_DECREF(surf);
 }
 
 static PyObject *
Tip: Filter by directory path e.g. /media app.js to search for public/media/app.js.
Tip: Use camelCasing e.g. ProjME to search for ProjectModifiedEvent.java.
Tip: Filter by extension type e.g. /repo .js to search for all .js files in the /repo directory.
Tip: Separate your search with spaces e.g. /ssh pom.xml to search for src/ssh/pom.xml.
Tip: Use ↑ and ↓ arrow keys to navigate and return to view the file.
Tip: You can also navigate files with Ctrl+j (next) and Ctrl+k (previous) and view the file with Ctrl+o.
Tip: You can also navigate files with Alt+j (next) and Alt+k (previous) and view the file with Alt+o.