Pull requests

#2 Open
Repository
nottheoilrig nottheoilrig
Branch
default
Repository
loewis loewis
Branch
default

testapp.py: Providers can make authentication responses with POST request method

Bitbucket cannot automatically merge this request due to conflicts.

Review the conflicts on the Overview tab. You can then either decline the request or merge it manually on your local system using the following commands:

hg update 
hg pull -r default https://bitbucket.org/nottheoilrig/openid2rp
Author
  1. nottheoilrig
Reviewers
Description

Hello again Martin von Lowis,

testapp.py doesn't work if the OpenID provider does the authentication response with a POST request method. It gives an error message: Unsupported method ("POST"). If you try the following OpenID it will reproduce the problem:

http://test-id.org/RP/POSTAssertion.aspx

To fix, I added a do_POST() method and factored the code for processing the authentication response from do_GET() into a new id_res() method (consistent with openid.mode: id_res). do_POST() reads parameters from the POST body only (as per the spec).

I checked it with the above OpenID and confirmed that it works now.

I'm happy to make any changes you request.

Thanks!

Comments (0)