#5 Merged
Repository
seocam
Branch
taggit
Repository
lorien
Branch
default

Replacing tagging by taggit

Author
  1. Sergio Oliveira
Reviewers
Description
  • django-tagging replaced by django-taggit which way more maintained than the first.
  • Updated version information to 0.3 and updated README changelog and dependencies.
  • Deps are also on requirements.txt file
  • feedzilla_tag_cloud template tag removed (can be done using {% include_tagcloud 'feedzilla.post' %} instead).

Comments (10)

  1. Sergio Oliveira author

    My main concern is regarding migrations. Even removing django-tagging as a dependency it will be required because migrations from 1 to 3 references it. The simplest solution would be reset all feedzilla migrations.

  2. lorien repo owner

    I have finally managed the merge with your branch.

    My main concern is regarding migrations. Even removing django-tagging as a dependency it will be required because migrations from 1 to 3 references it. The simplest solution would be reset all feedzilla migrations.

    There is a simple solution. Whenever you need to remove some dependency that is used by some migrations just modify your old migrations to use some basic type instead of type from the dependent package. In case of django-taggit I've just replaced TagField with CharField

    The actual concern is migration from django-tagging to django-taggit for live sites. I've done it but it took a bit more time as I thought. I also drop the django-taggit-templatetags dependency. It does not work correctly with custom tag field. I've created custom tag field for better support of building slugs from russian words.

    Also I've added "/demo" directory with demo project. There is README file insde that describes how to install demo.

  3. Sergio Oliveira author

    Hey lorien, are you planning to release a new version anytime soon?

    Next week I'm gonna delivery a project that depends on it and it would be good if the requirements.txt could point to an actual stable release.

    Cheers!

  4. lorien repo owner

    Hi Sergio. I've changed version to 0.22 and uploaded new app version to the PyPI. Is it what you mean with the word releasing? I can do just only this. In my mind releasing is associated with bugfixing, running tests for app features, testing app in production. I can't do all these things for feedzilla. I really did not know that someone uses feedzila untill you submitted your pull-request.

    The only thing I can say, latest version of feedzilla works on one of my sites and it seems it works fine.

  5. Sergio Oliveira author

    That's exactly what I meant by release! Thank you!! ;) You do track bugs and testing is definitely a good idea, I might be able to help a bit on that in the next months.

    Just to let you know I'm integrating Feedzilla on http://colab.interlegis.leg.br which is a collaboration tool used my legislators all over the the country (Brazil).

    Thanks for the app and for the quick responses.

    Cheers!