__call__ creates an endless loop

Issue #3 invalid
cjekel created an issue

Hi Lucas,

I hope all has been well.

I just noticed today that the __call__ routine in classicde.pyx creates an endless loop.

I think the following code

        while True:
            yield self.run(n_it)

should rather be something like this

        for i in range(n_it):
            yield self.run(1)

Happy to send a PR if you think this is the right.

Thanks,
CJ

Comments (3)

  1. Lucas Hermann Negri repo owner

    Hi, CJ.

    Thanks for contacting me. The current implementation is correct, as the user should ‘break' from the iteration when desired. The n_it argument controls the 'batch’ size, i. e, how many steps are done before yielding.

    Thanks.

  2. Log in to comment