Issue #238 resolved

Triple clicking misbehavior

epich
created an issue

When in evil-emacs-state, I can triple click a line and the whole line is selected. When in evil-normal-state, I triple click and the line very briefly becomes selected, then disappears.

Comments (3)

  1. Frank Fischer repo owner
    • changed status to open

    I can't reproduce that. As always, please provide a minimal example, preferably starting with make emacs from evil's source. And don't forget to tell us your Emacs version -- the mouse handling code in Emacs changes all the time ;)

  2. epich reporter

    I used the following .emacs:

    (add-to-list 'load-path "~/.emacs.d/evil")
    (require 'evil)
    (evil-mode 1)
    

    I witness the problem on version 24.2.90.1 on RHEL 5. Also reproduced in Emacs 24.2 on Windows 7.

  3. Frank Fischer repo owner

    Keep mouse selected visual selection after releasing the button.

    The mouse handling code deactivates the visual selection when the button is released and point has not been moved. While this is desired for character selection, it is not expected for word, line or block selections. This causes, e.g., the selected line to disappear if the button is released after triple clicking without moving point.

    The reason is that the visual selection does not correspond to (point) and (mark) in these cases. In fact, a visual line selection (and word or block selection) should always be considered as if point or mark has been changed.

    This change augments the point/mark test by adding a test whether the current visual selection type is line or block or if click-count equals 1 (which corresponds to word selection).

    This fixes #238.

    → <<cset 85fc2a79b8ed>>

  4. Log in to comment